-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add kustomization to standard example #2444
chore: add kustomization to standard example #2444
Conversation
|
This issue is currently awaiting triage. If kube-state-metrics contributors determine this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Welcome @sanadhis! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @sanadhis
kustomize edit fix --vars
gives me the following diff with 5.4.2 version of kustomize.
- - cluster-role.yaml
- - cluster-role-binding.yaml
- - service-account.yaml
- - deployment.yaml
- - service.yaml
+- cluster-role.yaml
+- cluster-role-binding.yaml
+- service-account.yaml
+- deployment.yaml
+- service.yaml
If you want you could remove the spaces but looks good otherwise as well.
@sanadhis can you add the suggested change from @kranurag7 ? Thanks! |
af6a042
to
7e4d9c8
Compare
7e4d9c8
to
2e4b3e4
Compare
@mrueg @kranurag7 thanks for the input. I have removed the spaces. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kranurag7, mrueg, sanadhis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This is additional, nice-to-have, add-ons for the user of kube-state-metrics + kustomization.
Having kustomization.yaml here will allow people to refer to this folder as whole using remote target:
How does this change affect the cardinality of KSM: (increases, decreases or does not change cardinality)
Does not change cardinality.