Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: resolve sync concerns #2204

Closed
wants to merge 1 commit into from

Conversation

rexagod
Copy link
Member

@rexagod rexagod commented Sep 20, 2023

  • defer to the later go version when merging back to main (and not the
    older version introduced in the release branch).
  • resolve merge conflicts.

Signed-off-by: Pranshu Srivastava [email protected]


To resolve #2203 (comment) (force-pushes are disable for release-*).

/cc @dgrisonnet

* defer to the later go version when merging back to main (and not the
  older version introduced in the release branch).
* resolve merge conflicts.

Signed-off-by: Pranshu Srivastava <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 20, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rexagod

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 20, 2023
@dgrisonnet
Copy link
Member

I don't think we should do that since the Kubernetes 1.27 deps are based on go 1.20.z.

I would prefer having the release-2.10 diverge away from master and stick to go 1.20.z whilst master is on 1.21.z

@rexagod
Copy link
Member Author

rexagod commented Sep 21, 2023

Makes sense, but wouldn't release-2.10 conflict with main? My plan was to resolve this on release-2.10 itself and create a release from the last commit before this one, so merging back into main wouldn't be an issue.

@dashpole
Copy link
Contributor

/assign @dgrisonnet
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 21, 2023
@dgrisonnet
Copy link
Member

Normally you should never have to rebase a release branch on main since it is meant to diverge away. I am not sure why the release process is like that here, but I don't think it will work well going forward if we have to continue keeping go version up-to-date on release branch.

@rexagod
Copy link
Member Author

rexagod commented Oct 3, 2023

/close

Since the superseding PR was closed as well, refer: #2203 (comment).

@k8s-ci-robot
Copy link
Contributor

@rexagod: Closed this PR.

In response to this:

/close

Since the superseding PR was closed as well.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants