-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: resolve sync concerns #2204
Conversation
* defer to the later go version when merging back to main (and not the older version introduced in the release branch). * resolve merge conflicts. Signed-off-by: Pranshu Srivastava <[email protected]>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rexagod The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I don't think we should do that since the Kubernetes 1.27 deps are based on go 1.20.z. I would prefer having the release-2.10 diverge away from master and stick to go 1.20.z whilst master is on 1.21.z |
Makes sense, but wouldn't |
/assign @dgrisonnet |
Normally you should never have to rebase a release branch on main since it is meant to diverge away. I am not sure why the release process is like that here, but I don't think it will work well going forward if we have to continue keeping go version up-to-date on release branch. |
/close Since the superseding PR was closed as well, refer: #2203 (comment). |
@rexagod: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
older version introduced in the release branch).
Signed-off-by: Pranshu Srivastava [email protected]
To resolve #2203 (comment) (force-pushes are disable for
release-*
)./cc @dgrisonnet