fix race condition in metrics handler

Signed-off-by: Walther Lee <[email protected]>
kubernetes · Sep 5, 2024 · 4aced25 · 4aced25
1 parent 082aba2
commit 4aced25
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/pkg/metricshandler/metrics_handler.go b/pkg/metricshandler/metrics_handler.go
@@ -72,7 +72,10 @@ func New(opts *options.Options, kubeClient kubernetes.Interface, storeBuilder ks
 // ReconfigureSharding reconfigures sharding with the current shard and totalShards, and
 // it's a no-op if both values are 0.
 func (m *MetricsHandler) ReconfigureSharding(ctx context.Context) {
-	if m.curShard == 0 && m.curTotalShards == 0 {
+	m.mtx.RLock()
+	hasShardsSet := m.curShard != 0 || m.curTotalShards != 0
+	m.mtx.RUnlock()
+	if !hasShardsSet {
 		return
 	}
 	m.ConfigureSharding(ctx, m.curShard, m.curTotalShards)