feat(chart): Add support for civo provider

[rbnis]

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds support for the Civo Cloud provider to the helm chart.

Special notes for your reviewer:

N/A

Does this PR introduce a user-facing change?

Support for civo provider added to helm chart

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: rbnis / name: Robin (d69e129)

[k8s-ci-robot]

Welcome @rbnis!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @rbnis. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Shubham82]

/ok-to-test

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[Shubham82]

/remove-lifecycle stale

[Shubham82]

@rbnis, please resolve the merge conflict.

[jackfrancis]

I don't see any template enforcement of this requirement (let me know if I'm missing something). Do you think we can add something that will integrate w/ the existing template spaghetti?

[rbnis]

I implemented this like the hetzner provider, there is also no validation.

But surely I could add an validation like this:
charts/cluster-autoscaler/templates/_validation.tpl:

{{- if eq .Values.cloudProvider "civo" -}}
  {{- if gt (len .Values.autoscalingGroups) 0 -}}
    When cloudProvider is set to "civo", autoscalingGroups must be provided.
  {{- end -}}
{{- end -}}

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rbnis
Once this PR has been reviewed and has the lgtm label, please assign gjtempleton for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• charts/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rbnis
Once this PR has been reviewed and has the lgtm label, please assign gjtempleton for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• charts/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[rbnis]

Sorry, for accidentally closing this PR. I just rebased it and responded to the open comment

[Shubham82]

Hi @jackfrancis, I think this PR is next in the queue for merging, (I checked the dashboard you created for Helm chart PR)
If it is then we can rebase this PR on top of the master and revise the chart version.

IMO, we consider this PR, as it has been open for a long time.

[Shubham82]

@rbnis, could you please resolve the merge conflict and the failed test case?

[rbnis]

@Shubham82 @jackfrancis
I just rebased this PR and fixed the Helm Docs test case.

[Shubham82]

Thanks @rbnis
/lgtm

[Shubham82]

cc @jackfrancis @gjtempleton
need your approval to merge this PR.