Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to the VPA admission-controller to reload it's certificate #6653

Closed
wants to merge 5 commits into from

Conversation

Nuckal777
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds the ability for the admission-controller to reload it's certificate on changes to the certificate file. This is useful when provisioning certificates with cert-manager.

Which issue(s) this PR fixes:

Fixes #6272.

Special notes for your reviewer:

This is based on #3462. I tried to implement the feedback already given there.

Does this PR introduce a user-facing change?

Added `reload-cert` flag to the VPA admission-controller, which will reload the certificates it use, when they change.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

None.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 25, 2024
Copy link

linux-foundation-easycla bot commented Mar 25, 2024

CLA Missing ID CLA Not Signed

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 25, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @Nuckal777!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @Nuckal777. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/vertical-pod-autoscaler labels Mar 25, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Nuckal777
Once this PR has been reviewed and has the lgtm label, please assign krzysied for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Shubham82
Copy link
Contributor

Hi @Nuckal777
you have to sign the CLA before the PR can be reviewed.
See the following document to sign the CLA: Signing Contributor License Agreements(CLA)

@Shubham82
Copy link
Contributor

To check EasyCLA

/easycla

@Nuckal777
Copy link
Contributor Author

Hey, @Shubham82 the commits I added to #3462 after rebasing are covered by the CLA. The commits from @surajnarwade were covered in #3462. I don't know if that is sufficient.

@Shubham82
Copy link
Contributor

Shubham82 commented Mar 26, 2024

@Nuckal777, it is due to the commits you added that do not belong to this repository. (means you rebased on commits that are not merged in kubernetes/autoscaler repo)
We always work or merge PR on the latest commits of the CA repo.

I think you have to delete those commits and then add those changes in the code yourself.

@Shubham82
Copy link
Contributor

see, the commits you added showed the following message:

This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

9623817
e40e828

@Nuckal777
Copy link
Contributor Author

Closing in favour of #6665.

@Nuckal777 Nuckal777 closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/vertical-pod-autoscaler cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VPA admission controller certificate is not reloaded
3 participants