-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to the VPA admission-controller to reload it's certificate #6653
Conversation
|
Welcome @Nuckal777! |
Hi @Nuckal777. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Nuckal777 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @Nuckal777 |
To check EasyCLA /easycla |
Hey, @Shubham82 the commits I added to #3462 after rebasing are covered by the CLA. The commits from @surajnarwade were covered in #3462. I don't know if that is sufficient. |
@Nuckal777, it is due to the commits you added that do not belong to this repository. (means you rebased on commits that are not merged in kubernetes/autoscaler repo) I think you have to delete those commits and then add those changes in the code yourself. |
Closing in favour of #6665. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds the ability for the admission-controller to reload it's certificate on changes to the certificate file. This is useful when provisioning certificates with cert-manager.
Which issue(s) this PR fixes:
Fixes #6272.
Special notes for your reviewer:
This is based on #3462. I tried to implement the feedback already given there.
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:
None.