Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify VPA and HPA limitations when scaling on resource metrics #6616

Merged

Conversation

dippynark
Copy link
Contributor

@dippynark dippynark commented Mar 12, 2024

What type of PR is this?

/kind documentation

What this PR does / why we need it:

Clarifies whether it's possible to use VPA together with HPA on separate resource metrics

Which issue(s) this PR fixes:

Fixes #6247

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/vertical-pod-autoscaler labels Mar 12, 2024
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 12, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @dippynark!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 12, 2024
Signed-off-by: Luke Addison <lukeaddison785@gmail.com>
@dippynark dippynark force-pushed the clarify-vpa-hpa-limitations branch from ca94f04 to 804c635 Compare March 12, 2024 12:42
@dippynark dippynark changed the title WIP: docs: Clarify VPA and HPA limitations Clarify VPA and HPA resource metric limitations Mar 12, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 12, 2024
@dippynark dippynark changed the title Clarify VPA and HPA resource metric limitations Clarify VPA and HPA resource metrics limitations Mar 12, 2024
@dippynark dippynark changed the title Clarify VPA and HPA resource metrics limitations Clarify VPA and HPA limitations when scaling on resource metrics Mar 12, 2024
@dippynark
Copy link
Contributor Author

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Mar 12, 2024
@Shubham82
Copy link
Contributor

Thanks, @dippynark for the PR.
It looks good to me,
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 13, 2024
@voelzmo
Copy link
Contributor

voelzmo commented Mar 13, 2024

Looks great, thanks so much for following up on this, @dippynark!
/lgtm

Copy link
Contributor

@mwielgus mwielgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dippynark, mwielgus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit 65db534 into kubernetes:master Mar 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can the VPA and HPA be used together on separate resource metrics?
5 participants