CA FAQ: clarify the point about scheduling constraints blocking scale-down #6567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: towca The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
area/cluster-autoscaler
cncf-cla: yes
Closed
Shubham82
suggested changes
Feb 27, 2024
| @@ -96,8 +96,13 @@ Cluster Autoscaler decreases the size of the cluster when some nodes are consist | |||
| "cluster-autoscaler.kubernetes.io/safe-to-evict-local-volumes": "volume-1,volume-2,.." | |||
| ``` | |||
| and all of the pod's local volumes are listed in the annotation value. | |||
| * Pods that cannot be moved elsewhere due to various constraints (lack of resources, non-matching node selectors or affinity, | |||
| matching anti-affinity, etc) | |||
| * Pods that cannot be moved elsewhere due to scheduling constraints. CA simulates kube-scheduler behavior, and if there's no other node where a given pod can schedule, the pod's node won't be scaled down. | |||
There was a problem hiding this comment.
Suggested change
| * Pods that cannot be moved elsewhere due to scheduling constraints. CA simulates kube-scheduler behavior, and if there's no other node where a given pod can schedule, the pod's node won't be scaled down. | |
| * Pods that cannot be moved elsewhere due to scheduling constraints. CA simulates | |
| kube-scheduler behavior, and if there's no other node where a given pod can schedule, the | |
| pod's node won't be scaled down. |
There was a problem hiding this comment.
Just a small nit: Wrap the line
| * Pods that cannot be moved elsewhere due to various constraints (lack of resources, non-matching node selectors or affinity, | ||
| matching anti-affinity, etc) | ||
| * Pods that cannot be moved elsewhere due to scheduling constraints. CA simulates kube-scheduler behavior, and if there's no other node where a given pod can schedule, the pod's node won't be scaled down. | ||
| * This can be particularly visible if a given workloads' pods are configured to only fit one pod per node on some subset of nodes. Such pods will always block CA from scaling down their nodes, because all |
There was a problem hiding this comment.
Suggested change
| * This can be particularly visible if a given workloads' pods are configured to only fit one pod per node on some subset of nodes. Such pods will always block CA from scaling down their nodes, because all | |
| * This can be particularly visible if a given workloads' pods are configured to only fit | |
| one pod per node on some subset of nodes. Such pods will always block CA from scaling | |
| down their nodes, because all |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompted by #6208