feature: Support Hetzner cloud provider in Helm chart

[NiklasRosenstein]

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds support for the Hetzner cloud provider in the cluster-autoscaler Helm chart.

Which issue(s) this PR fixes:

n/a

Special notes for your reviewer:

n/a

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

n/a

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: NiklasRosenstein / name: Niklas Rosenstein (6f5810e, 1410185, 7ec2259, 6b78974, a8e00f4, 14f4c27, 9d73b59, b2e3b7a, c49eefe)

[k8s-ci-robot]

Welcome @NiklasRosenstein!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[Shubham82]

Hi @NiklasRosenstein
Please address the failed Test Cases i.e. Lint and Test Charts / Helm chart (pull_request) and Lint and Test Charts / Helm Docs (pull_request), that are required to be passed.

JFYI: you have to install Pre-commit hooks before working in the Charts.

[Shubham82]

The Lint and Test Charts / Helm chart (pull_request) test case failed due to not doing a bump version:
✖︎ cluster-autoscaler => (version: "9.34.1", path: "charts/cluster-autoscaler") > Chart version not ok. Needs a version bump!

So you need to bump the chart version to 9.34.2 as it can't publish a new chart otherwise.

[Shubham82]

The Lint and Test Charts / Helm Docs (pull_request) test case failed because you directly did the changes in the README.md, we use Pre-commit hooks to update README.md file.

So The README.md is generated by helm-docs from the README.md.gotmpl file, which is one of our pre-commit hooks. So if you want to make changes to the README other than those in the values.yaml file, you will need to make changes in the README.md.gotmpl file.

[NiklasRosenstein]

Thanks @Shubham82, and sorry for not reading up on the contribution guidelines!

Just want to mention as a side note that your CI is using helm-docs 1.3.0 which doesn't seem to support an extra empty line in the values.yaml comments:

diff --git a/charts/cluster-autoscaler/values.yaml b/charts/cluster-autoscaler/values.yaml
index 5503dda51..b838afbf1 100644
--- a/charts/cluster-autoscaler/values.yaml
+++ b/charts/cluster-autoscaler/values.yaml
@@ -36,7 +36,6 @@ autoDiscovery:
 #   maxSize: 2<br />
 #   minSize: 1
 # </pre>
-#
 # For Hetzner Cloud, the `instanceType` and `region` keys are also required.
 # <pre>
 # - name: mypool<br />

The version I got with brew install norwoodj/tap/helm-docs today is 1.12.0 which does seem to support it and it proved a minor hiccup to get the CI to pass. I was able to run the older version with

$ docker run --rm -it --workdir /github/workspace -v $PWD:/github/workspace jnorwood/helm-docs:v1.3.0
INFO[2024-02-06T22:29:00Z] Found Chart directories [charts/cluster-autoscaler] 
INFO[2024-02-06T22:29:00Z] Generating README Documentation for chart /github/workspace/charts/cluster-autoscaler 

[mwielgus]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mwielgus, NiklasRosenstein

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• charts/OWNERS [mwielgus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment