Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ProvisioningRequestPodsFilter processor #6386

Merged
merged 2 commits into from
Jan 3, 2024
Merged

Add ProvisioningRequestPodsFilter processor #6386

merged 2 commits into from
Jan 3, 2024

Conversation

yaroslava-serdiuk
Copy link
Contributor

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 18, 2023
@k8s-ci-robot k8s-ci-robot requested a review from x13n December 18, 2023 16:37
@yaroslava-serdiuk yaroslava-serdiuk force-pushed the provreq branch 6 times, most recently from b821e53 to 1e1be97 Compare December 19, 2023 08:00
kisieland
kisieland reviewed Dec 19, 2023
View reviewed changes
cluster-autoscaler/config/autoscaling_options.go Outdated Show resolved Hide resolved
cluster-autoscaler/processors/provreq/provisioning_request_pods_filter.go Outdated Show resolved Hide resolved
cluster-autoscaler/processors/provreq/provisioning_request_pods_filter.go Outdated Show resolved Hide resolved
cluster-autoscaler/processors/provreq/provisioning_request_pods_filter.go Outdated Show resolved Hide resolved
cluster-autoscaler/processors/provreq/provisioning_request_pods_filter.go Outdated Show resolved Hide resolved
cluster-autoscaler/processors/provreq/provisioning_request_pods_filter.go Outdated Show resolved Hide resolved
cluster-autoscaler/processors/provreq/provisioning_request_pods_filter.go Outdated Show resolved Hide resolved
cluster-autoscaler/processors/provreq/provisioning_request_pods_filter.go Outdated Show resolved Hide resolved
cluster-autoscaler/processors/provreq/provisioning_request_pods_filter.go Outdated Show resolved Hide resolved
cluster-autoscaler/provisioningrequest/provreqclient/client.go Outdated Show resolved Hide resolved
@yaroslava-serdiuk yaroslava-serdiuk force-pushed the provreq branch 2 times, most recently from a8e12e9 to c92c5f1 Compare December 20, 2023 12:14
kisieland
kisieland reviewed Dec 20, 2023
View reviewed changes
Copy link
Contributor

@kisieland kisieland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple more comments

cluster-autoscaler/processors/provreq/provisioning_request_processors_test.go Show resolved Hide resolved
cluster-autoscaler/provisioningrequest/provreqclient/client.go Outdated Show resolved Hide resolved
cluster-autoscaler/provisioningrequest/provreqclient/client.go Outdated Show resolved Hide resolved
cluster-autoscaler/provisioningrequest/provreqclient/client.go Show resolved Hide resolved
@yaroslava-serdiuk yaroslava-serdiuk force-pushed the provreq branch 2 times, most recently from e1afc78 to 4bfc6f7 Compare December 20, 2023 14:00
@yaroslava-serdiuk yaroslava-serdiuk force-pushed the provreq branch 3 times, most recently from febb424 to dea3f7a Compare December 20, 2023 14:56
@kisieland
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@kisieland: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@yaroslava-serdiuk yaroslava-serdiuk changed the title Add ProvisioningRequest processors Add ProvisioningRequestPodsFilter processor Dec 21, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 21, 2023
@x13n
Copy link
Member

x13n commented Dec 29, 2023

Assigning, since you're already looking into this.

/assign @kisieland

Please assign to me (or another code owner) after LGTMing.

@kisieland
Copy link
Contributor

@yaroslava-serdiuk please resolve the merge conflicts on the PR and it should be ready for review by @x13n

x13n
x13n requested changes Dec 29, 2023
View reviewed changes
Copy link
Member

@x13n x13n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign

Took a look, just a few comments.

cluster-autoscaler/processors/pods/pod_list_processor.go Outdated Show resolved Hide resolved
cluster-autoscaler/go.mod Outdated Show resolved Hide resolved
cluster-autoscaler/processors/provreq/provisioning_request_processors.go Outdated Show resolved Hide resolved
cluster-autoscaler/provisioningrequest/provreqclient/client.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 2, 2024
@yaroslava-serdiuk yaroslava-serdiuk force-pushed the provreq branch 2 times, most recently from b7672fc to 164e53f Compare January 2, 2024 12:15
@yaroslava-serdiuk yaroslava-serdiuk force-pushed the provreq branch 3 times, most recently from 0633fea to f4c0407 Compare January 2, 2024 13:28
x13n
x13n reviewed Jan 3, 2024
View reviewed changes
Copy link
Member

@x13n x13n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one minor comment, feel free to ignore. Putting PR on hold in case you want to address it.

/lgtm
/approve
/hold

cluster-autoscaler/main.go
@@ -250,6 +251,7 @@ var (
"--max-graceful-termination-sec flag should not be set when this flag is set. Not setting this flag will use unordered evictor by default."+
"Priority evictor reuses the concepts of drain logic in kubelet(https://github.com/kubernetes/enhancements/tree/master/keps/sig-node/2712-pod-priority-based-graceful-node-shutdown#migration-from-the-node-graceful-shutdown-feature)."+
"Eg. flag usage: '10000:20,1000:100,0:60'")
provisioningRequestsEnabled = flag.Bool("enable-provisioning-requests", false, "Whether the clusterautoscaler will be handling the ProvisioningRequest CRs.")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I'd avoid mentioning clusterautoscaler in the description. It is a flag to clusterautoscaler binary, so saying the flag will affect clusterautoscaler is a bit redundant.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the alternative is to put it in passive voice, but I don't think it's necessary. We already mention clusterautoscaler in many flags.

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Jan 3, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: x13n, yaroslava-serdiuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 3, 2024
@yaroslava-serdiuk
Copy link
Contributor Author

/label tide/merge-method-squash
/unhold

@k8s-ci-robot k8s-ci-robot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jan 3, 2024
@k8s-ci-robot k8s-ci-robot merged commit d29ffd0 into kubernetes:master Jan 3, 2024
6 checks passed
@vbhargav875 vbhargav875 mentioned this pull request Jan 29, 2024
Merged
@yaroslava-serdiuk
Copy link
Contributor Author

#6814

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kisieland kisieland kisieland left review comments

@x13n x13n x13n requested changes

@BigDarkClown BigDarkClown Awaiting requested review from BigDarkClown

Assignees

@x13n x13n

@kisieland kisieland

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yaroslava-serdiuk @kisieland @k8s-ci-robot @x13n