Update VPA client-go version from v0.26.1 to v0.27.5

[sophieliu15]

What type of PR is this?

/kind cleanup

[k8s-ci-robot]

Welcome @sophieliu15!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: laoj2, sophieliu15
Once this PR has been reviewed and has the lgtm label, please assign kgolab for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• vertical-pod-autoscaler/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[laoj2]

@sophieliu15 the tests are failing with

rror: pkg/recommender/input/cluster_feeder.go:178:41: cannot use oomObserver (variable of type *oom.observer) as "k8s.io/client-go/tools/cache".ResourceEventHandler value in argument to newPodClients: *oom.observer does not implement "k8s.io/client-go/tools/cache".ResourceEventHandler (wrong type for method OnAdd)
		have OnAdd(interface{}, bool)
		want OnAdd(interface{})
Error: pkg/recommender/input/cluster_feeder.go:179:45: cannot use oomObserver (variable of type *oom.observer) as oom.Observer value in argument to WatchEvictionEventsWithRetries: *oom.observer does not implement oom.Observer (wrong type for method OnAdd)
		have OnAdd(interface{}, bool)
		want OnAdd(interface{})
Error: pkg/recommender/input/cluster_feeder.go:180:20: cannot use oomObserver (variable of type *oom.observer) as oom.Observer value in return statement: *oom.observer does not implement oom.Observer (wrong type for method OnAdd)
		have OnAdd(interface{}, bool)
		want OnAdd(interface{})

So, we need to update vendor/ to reflect your go.mod changes:

go mod tidy
go mod vendor

[sophieliu15]

Sophie Liu the tests are failing with

rror: pkg/recommender/input/cluster_feeder.go:178:41: cannot use oomObserver (variable of type *oom.observer) as "k8s.io/client-go/tools/cache".ResourceEventHandler value in argument to newPodClients: *oom.observer does not implement "k8s.io/client-go/tools/cache".ResourceEventHandler (wrong type for method OnAdd)
		have OnAdd(interface{}, bool)
		want OnAdd(interface{})
Error: pkg/recommender/input/cluster_feeder.go:179:45: cannot use oomObserver (variable of type *oom.observer) as oom.Observer value in argument to WatchEvictionEventsWithRetries: *oom.observer does not implement oom.Observer (wrong type for method OnAdd)
		have OnAdd(interface{}, bool)
		want OnAdd(interface{})
Error: pkg/recommender/input/cluster_feeder.go:180:20: cannot use oomObserver (variable of type *oom.observer) as oom.Observer value in return statement: *oom.observer does not implement oom.Observer (wrong type for method OnAdd)
		have OnAdd(interface{}, bool)
		want OnAdd(interface{})

So, we need to update vendor/ to reflect your go.mod changes:

go mod tidy
go mod vendor

I believe we also need to bump the version in e2e/. However, the go version there is really old. Luckily #6258 is bumping the go version in that directory. We can merge that PR first then I will rebase and add my change

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sophieliu15]

Actually this PR is not required. The client-go version is bumped in #6258 to v0.28.3 and the method was updated to include the additional parameter: https://github.com/kubernetes/autoscaler/blob/master/vertical-pod-autoscaler/pkg/recommender/input/oom/observer.go#L135