Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix '.spec.updatePolicy.evictionRequirements.resources' to be plural in yaml #6251

Merged

Conversation

voelzmo
Copy link
Contributor

@voelzmo voelzmo commented Nov 6, 2023

What type of PR is this?

/kind bug

What this PR does / why we need it:

Fix '.spec.updatePolicy.evictionRequirements.resources' to be plural in yaml. Seems like this slipped through the cracks in #5599. We didn't release the CRD yet, so changing it shouldn't be an issue?

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 6, 2023
@k8s-ci-robot k8s-ci-robot added area/vertical-pod-autoscaler size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 6, 2023
@Shubham82
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 7, 2023
@mwielgus
Copy link
Contributor

Just to be on the safe side, this part of api has not been actually released yet, right?

@voelzmo
Copy link
Contributor Author

voelzmo commented Nov 16, 2023

Just to be on the safe side, this part of api has not been actually released yet, right?

Correct, that's what I tried to say in the first post of the PR

We didn't release the CRD yet, so changing it shouldn't be an issue?

@voelzmo
Copy link
Contributor Author

voelzmo commented Nov 22, 2023

Before we do a new release, can we please merge this to avoid modifying a released CRD?
I'm asking because I stumbled upon #6276
/cc @sophieliu15

@sophieliu15
Copy link

/lgtm

@sophieliu15
Copy link

@kwiesmueller Kevin, could you review and merge this change?

@kwiesmueller
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwiesmueller, voelzmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit 8673628 into kubernetes:master Nov 22, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/vertical-pod-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants