-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix '.spec.updatePolicy.evictionRequirements.resources' to be plural in yaml #6251
Fix '.spec.updatePolicy.evictionRequirements.resources' to be plural in yaml #6251
Conversation
/lgtm |
Just to be on the safe side, this part of api has not been actually released yet, right? |
Correct, that's what I tried to say in the first post of the PR
|
Before we do a new release, can we please merge this to avoid modifying a released CRD? |
/lgtm |
@kwiesmueller Kevin, could you review and merge this change? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwiesmueller, voelzmo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix '.spec.updatePolicy.evictionRequirements.resources' to be plural in yaml. Seems like this slipped through the cracks in #5599. We didn't release the CRD yet, so changing it shouldn't be an issue?