-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update addon-resizer non-root running #6242
update addon-resizer non-root running #6242
Conversation
Welcome @zhangguanzhang! |
/assign @sophieliu15 |
@kwiesmueller: GitHub didn't allow me to assign the following users: sophieliu15. Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This change LGTM. @kwiesmueller Could you do a final round of review then approve if it looks good to you? |
I just noticed that this is against the master branch. addon-resizer is highly outdated on the master branch. Please rebase your change against https://github.com/kubernetes/autoscaler/tree/addon-resizer-release-1.8/addon-resizer |
47df360
to
51f4c08
Compare
all had done |
/lgtm |
/ok-to-test |
😉seem need |
Sorry about that. |
@kwiesmueller Could you provide a lgtm label then assign this PR to @wojtek-t for approval? See #6242 (comment) for details. |
/lgtm |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kwiesmueller, wojtek-t, zhangguanzhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4406357
into
kubernetes:addon-resizer-release-1.8
What type of PR is this?
running on non-root user
/kind feature
What this PR does / why we need it:
for security
Special notes for your reviewer: