Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update addon-resizer non-root running #6242

Merged

Conversation

zhangguanzhang
Copy link

@zhangguanzhang zhangguanzhang commented Nov 2, 2023

What type of PR is this?

running on non-root user
/kind feature

What this PR does / why we need it:

for security

Special notes for your reviewer:

[root@xxx ~]# docker ps -a | grep -m1 addon-resizer
3d1e321b83e6   c34e5cebf87d                    "/pod_nanny --contai…"   20 hours ago   Up 20 hours                           k8s_addon-resizer_kube-state-metrics-57b5dfb58d-x4ks8_kube-system_3abe5325-2b42-407f-b955-efe311254c3c_0
[root@xxx~]# docker top 3d1e
UID            PID          PPID           C      STIME         TTY           TIME                CMD
nfsnobo+       6068         6049           0      Nov02         ?              00:01:09            /pod_nanny --container=kube-state-metrics --healthcheck-address=:8082 --cpu=100m --extra-cpu=1m --memory=100Mi --extra-memory=2Mi --threshold=5 --deployment=kube-state-metrics

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 2, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @zhangguanzhang!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/addon-resizer labels Nov 2, 2023
@kwiesmueller
Copy link
Member

/assign @sophieliu15

@k8s-ci-robot
Copy link
Contributor

@kwiesmueller: GitHub didn't allow me to assign the following users: sophieliu15.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @sophieliu15

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sophieliu15
Copy link

This change LGTM. @kwiesmueller Could you do a final round of review then approve if it looks good to you?

@zhangguanzhang
Copy link
Author

@kwiesmueller @sophieliu15 ping

@kwiesmueller
Copy link
Member

I just noticed that this is against the master branch. addon-resizer is highly outdated on the master branch. Please rebase your change against https://github.com/kubernetes/autoscaler/tree/addon-resizer-release-1.8/addon-resizer
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2023
@zhangguanzhang zhangguanzhang changed the base branch from master to addon-resizer-release-1.8 November 8, 2023 04:25
@zhangguanzhang
Copy link
Author

I just noticed that this is against the master branch. addon-resizer is highly outdated on the master branch. Please rebase your change against https://github.com/kubernetes/autoscaler/tree/addon-resizer-release-1.8/addon-resizer /hold

all had done

@kwiesmueller
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 8, 2023
@kwiesmueller
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Nov 8, 2023
@zhangguanzhang
Copy link
Author

😉seem need /approve and /hold cancel

@kwiesmueller
Copy link
Member

Sorry about that.
/hold cancel
/approve

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 9, 2023
@sophieliu15
Copy link

@kwiesmueller Could you provide a lgtm label then assign this PR to @wojtek-t for approval?

See #6242 (comment) for details.

@kwiesmueller
Copy link
Member

/lgtm
/assign @wojtek-t

@wojtek-t
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kwiesmueller, wojtek-t, zhangguanzhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 10, 2023
@k8s-ci-robot k8s-ci-robot merged commit 4406357 into kubernetes:addon-resizer-release-1.8 Nov 10, 2023
2 checks passed
@zhangguanzhang zhangguanzhang deleted the patch-1 branch November 10, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/addon-resizer cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants