Add possbility to override the max size fo groups #6229
Conversation
This allowes for more control over for the CA scale-up simulation.
k8s-ci-robot
added
cncf-cla: yes
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jayantjain93, kisieland The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -76,7 +74,7 @@ func groupPodsBySchedulingProperties(pods []*apiv1.Pod) map[equivalenceGroupId][ | |||
| podEquivalenceGroups[*gid] = append(podEquivalenceGroups[*gid], pod) | |||
| continue | |||
| } | |||
| if len(egs) < maxEquivalenceGroupsByController { | |||
| if len(egs) < maxPodsPerGroup { | |||
There was a problem hiding this comment.
Wait, this used to be # of equivalence groups per controller and now you're suddenly using max pods per group here. What problem are you trying to solve?
|
1000 similar pods should only result in one pod equivalence group. If there's more groups, it means they are not similar. Maybe you're hitting a problem because of some criterium we should add to the pod equivalence comparison? |
|
Thanks @x13n, the pods were missing the Controller flag to be grouped. |
This allowes for more control over for the CA scale-up simulation.
What type of PR is this?
What this PR does / why we need it:
Allows users to control the size of the pods per group in the simulation.
This will help in cases where multiple similar pods are being scheduled.
The original hard-coded value of 10 was limiting in cases where there are 1000 of similar pods being created at once.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: