Bump CA golang to 1.21 #6220
Merged
Bump CA golang to 1.21 #6220
+21
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/cleanup
x13n
reviewed
Oct 26, 2023
azylinski
force-pushed
the
bump-go-1.21
branch
from
6fd6897 to
85e97c2
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Right, this is outside of CA dir. @gjtempleton can you approve this? |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: azylinski, gjtempleton, x13n The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Bump cluster-autoscaler golang version to 1.21.
The Docker build was already using
golang:1.21.3- it's only the CI and go.mod that was lacking behind.K/K is already on 1.21.3 as well: https://github.com/kubernetes/kubernetes/blob/master/.go-version
With upgrade, I've removed min/max functions, which are now build-in: https://tip.golang.org/ref/spec#Min_and_max
Does this PR introduce a user-facing change?