Rules type must implement Rule interface

[jbartosik]

The interface changed in #6196 but the Rules class didn't

/kind bug
/kind cleanup

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jbartosik
Once this PR has been reviewed and has the lgtm label, please assign towca for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• cluster-autoscaler/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[x13n]

I don't think Rules has to implement the Rule interface at all - it represents a collection, so adding a name seems quite artificial.

[jbartosik]

I don't think Rules has to implement the Rule interface at all - it represents a collection, so adding a name seems quite artificial.

It already implements Drainable which looks to me like it's more of a composite rule than a collection of rules

[x13n]

The fact the it did implement the interface before doesn't imply we want it to continue doing so.

/close

[k8s-ci-robot]

@x13n: Closed this PR.

In response to this:

The fact the it did implement the interface before doesn't imply we want it to continue doing so.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.