Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds and implements node taints count metric. #6201

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Adds and implements node taints count metric. #6201

merged 1 commit into from
Oct 23, 2023
+226 −45

Conversation

piotrwrotniak
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

Adds and implements node taints count metric.

Does this PR introduce a user-facing change?

Adds and implements node taints count metric.

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 17, 2023
@k8s-ci-robot k8s-ci-robot requested a review from feiskyer October 17, 2023 15:20
@k8s-ci-robot k8s-ci-robot requested a review from x13n October 17, 2023 15:20
@piotrwrotniak piotrwrotniak changed the title Reports node taints count. Adds and implements node taints count metric. Oct 17, 2023
x13n
x13n requested changes Oct 20, 2023
View reviewed changes
Copy link
Member

@x13n x13n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the change!

cluster-autoscaler/utils/taints/taints.go Outdated Show resolved Hide resolved
cluster-autoscaler/utils/taints/taints.go Outdated Show resolved Hide resolved
cluster-autoscaler/proposals/metrics.md Outdated Show resolved Hide resolved
cluster-autoscaler/utils/taints/taints.go Outdated Show resolved Hide resolved
@piotrwrotniak piotrwrotniak requested a review from x13n October 20, 2023 13:42
@piotrwrotniak
Copy link
Contributor Author

/assign

@piotrwrotniak piotrwrotniak removed their assignment Oct 23, 2023
@x13n
Copy link
Member

x13n commented Oct 23, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 23, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: piotrwrotniak, x13n

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5cea330 into kubernetes:master Oct 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feiskyer feiskyer Awaiting requested review from feiskyer

@x13n x13n Awaiting requested review from x13n

Assignees

@x13n x13n

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@piotrwrotniak @x13n @k8s-ci-robot