Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md: Link to Cluster-API #6194

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

guettli
Copy link
Contributor

@guettli guettli commented Oct 13, 2023

Add Link to Cluster API.

What type of PR is this?

/kind documentation

@k8s-ci-robot k8s-ci-robot added kind/documentation Categorizes issue or PR as related to documentation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/helm-charts labels Oct 13, 2023
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 13, 2023
@Shubham82
Copy link
Contributor

@guettli Please address the failed Test Cases i.e. Lint and Test Charts / Helm chart (pull_request) and Lint and Test Charts / Helm Docs (pull_request), that are required to be passed.

@Shubham82
Copy link
Contributor

The Lint and Test Charts / Helm chart (pull_request) test case failed due to not doing a bump version:
✖︎ cluster-autoscaler => (version: "9.29.3", path: "charts/cluster-autoscaler") > Chart version not ok. Needs a version bump!

So you need to bump the chart version to 9.29.4 as it can't publish a new chart otherwise.

@Shubham82
Copy link
Contributor

The Lint and Test Charts / Helm Docs (pull_request) test case failed because you directly did the changes in the README.md, we use Pre-commit hooks to update README.md file.

So The README.md is generated by helm-docs from the README.md.gotmpl file, which is one of our pre-commit hooks. So if you want to make changes to the README other than those in the values.yaml file, you will need to make changes in the README.md.gotmpl file.

@guettli guettli force-pushed the patch-2 branch 2 times, most recently from d3f2549 to a156083 Compare October 16, 2023 11:23
@Shubham82
Copy link
Contributor

@guettli still both the test cases failed.
Please address these failed test cases.

@Shubham82
Copy link
Contributor

you have to install Pre-commit hooks before working in the Charts.

For Lint and Test Charts / Helm chart (pull_request) you have to bump the chart version to 9.29.4.

For Lint and Test Charts / Helm Docs (pull_request) once you update the README.md.gotmpl file, Pre-commit hooks(running at the time of committing the changes) make the changes in README when you commit the changes.

@Shubham82
Copy link
Contributor

Thanks @guettli
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2023
charts/cluster-autoscaler/Chart.yaml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 15, 2023
@k8s-ci-robot k8s-ci-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 15, 2023
@guettli guettli requested a review from gjtempleton November 15, 2023 07:56
@Shubham82
Copy link
Contributor

@guettli you need to bump the chart version to 9.30.1 so that the failed test case will be passed.

Add Link to Cluster API.
@guettli
Copy link
Contributor Author

guettli commented Nov 15, 2023

@guettli you need to bump the chart version to 9.30.1 so that the failed test case will be passed.

@Shubham82 is it fine now?

@Shubham82
Copy link
Contributor

@guettli you need to bump the chart version to 9.30.1 so that the failed test case will be passed.

@Shubham82 is it fine now?

yeah, All test cases are passed
Thanks!

@Shubham82
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 15, 2023
@gjtempleton gjtempleton dismissed their stale review November 15, 2023 17:33

Comment addressed

@gjtempleton
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gjtempleton, guettli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 15, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6a7e6a2 into kubernetes:master Nov 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/helm-charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants