Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vpa-up.sh script by removing duplicate recommender #6151

Merged
merged 1 commit into from
Sep 27, 2023
Merged

Fix vpa-up.sh script by removing duplicate recommender #6151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions vertical-pod-autoscaler/hack/vpa-process-yamls.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,17 +40,16 @@ if [ $# -gt 2 ]; then
fi

ACTION=$1
COMPONENTS="vpa-v1-crd-gen vpa-rbac updater-deployment recommender-deployment admission-controller-deployment recommender-externalmetrics-deployment"
TEST_COMPONENTS=(recommender-externalmetrics-deployment)
COMPONENTS="vpa-v1-crd-gen vpa-rbac updater-deployment recommender-deployment admission-controller-deployment"

function script_path {
# Regular components have deployment yaml files under /deploy/. But some components only have
# test deployment yaml files that are under hack/e2e. If $1 is one of ${TEST_COMPONENTS}, use
# the hack/e2e subdir instead of deploy.
if printf '%s\0' "${TEST_COMPONENTS[@]}" | grep -Fqxz -- $1; then
echo "${SCRIPT_ROOT}/hack/e2e/${1}.yaml"
else
# test deployment yaml files that are under hack/e2e. Check the main deploy directory before
# using the e2e subdirectory.
if test -f "${SCRIPT_ROOT}/deploy/${1}.yaml"; then
echo "${SCRIPT_ROOT}/deploy/${1}.yaml"
else
echo "${SCRIPT_ROOT}/hack/e2e/${1}.yaml"
fi
}

Expand Down
Loading