Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hetzner node specific cloud init #5645

Closed
wants to merge 4 commits into from
Closed

Hetzner node specific cloud init #5645

wants to merge 4 commits into from

Conversation

marcwickenden
Copy link

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds the ability to provide a different cloud-init and public IP value for each pool. This was developed specifically to address the need to label each autoscaling group differently but could enable far greater customisation of the node through cloud-init.

Existing functionality is maintained as the default operation if pool-specific environment variables are not set.

Which issue(s) this PR fixes:

Fixes #4604

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Added the ability to customise the cloud-init and public IP address settings for Hetzner Cloud autoscale nodes.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 31, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 31, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: marcwickenden
Once this PR has been reviewed and has the lgtm label, please assign apricote for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Mar 31, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @marcwickenden!

It looks like this is your first PR to kubernetes/autoscaler 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/autoscaler has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Mar 31, 2023
apricote
apricote reviewed Apr 3, 2023
View reviewed changes
cluster-autoscaler/cloudprovider/hetzner/hetzner_cloud_provider.go
@@ -206,6 +208,63 @@ func BuildHetzner(_ config.AutoscalingOptions, do cloudprovider.NodeGroupDiscove
klog.Fatalf("Failed to get servers for for node pool %s error: %v", nodegroupSpec, err)
}

// Get this node's cloud-init
var cloudInitBase64 string
nodeCloudInitVar := fmt.Sprintf("HCLOUD_%s_CLOUD_INIT", strings.ToUpper(spec.name))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has the potential of conflicts when two node pools with the same name but different cases, ( pool vs Pool) exist. While I dont think that anyone actually uses it like that, those are valid node pool names according to validNodePoolName regex.

Same "complaint" applies to nodePublicIPv4Var & nodePublicIPv6Var

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did wonder about taking this semi-magical approach to be honest. Upper-casing was really for aesthetic purposes to avoid HCLOUD_pool_CLOUD_INIT but that's not that important. I actually think a better approach probably is to add some additional fields to the --nodes parameter as it removes the need to things like this.

@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 13, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 12, 2023
@x13n
Copy link
Member

x13n commented Sep 14, 2023

This PR looks very stale, closing for now. Please reopen if still relevant.

/close

@k8s-ci-robot
Copy link
Contributor

@x13n: Closed this PR.

In response to this:

This PR looks very stale, closing for now. Please reopen if still relevant.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apricote apricote apricote left review comments

@feiskyer feiskyer Awaiting requested review from feiskyer

Assignees
No one assigned
Labels
area/cluster-autoscaler cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HETZNER - Custom Labels on scaled nodes
5 participants
@marcwickenden @k8s-ci-robot @k8s-triage-robot @x13n @apricote