-
Notifications
You must be signed in to change notification settings - Fork 4k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Convert pdb check to drainability rule
- Loading branch information
Showing
4 changed files
with
219 additions
and
25 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 changes: 54 additions & 0 deletions
54
cluster-autoscaler/simulator/drainability/rules/pdb/pdb.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
| /* | ||
| Copyright 2023 The Kubernetes Authors. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package pdb | ||
|
|
||
| import ( | ||
| "fmt" | ||
|
|
||
| apiv1 "k8s.io/api/core/v1" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/apimachinery/pkg/labels" | ||
| "k8s.io/autoscaler/cluster-autoscaler/simulator/drainability" | ||
| "k8s.io/autoscaler/cluster-autoscaler/utils/drain" | ||
| ) | ||
|
|
||
| // Rule is a drainability rule on how to handle pods with pdbs. | ||
| type Rule struct{} | ||
|
|
||
| // New creates a new Rule. | ||
| func New() *Rule { | ||
| return &Rule{} | ||
| } | ||
|
|
||
| // Drainable decides how to handle pods with pdbs on node drain. | ||
| func (Rule) Drainable(drainCtx *drainability.DrainContext, pod *apiv1.Pod) drainability.Status { | ||
| // TODO: Replace this logic with RemainingPdbTracker.CanRemovePods() after | ||
| // deprecating legacy scale down. Depending on the implementation, this may | ||
| // require adding information to the DrainContext, such as the slice of pods | ||
| // and a flag to prevent duplicate checks. | ||
| for _, pdb := range drainCtx.Pdbs { | ||
| selector, err := metav1.LabelSelectorAsSelector(pdb.Spec.Selector) | ||
| if err != nil { | ||
| return drainability.NewBlockedStatus(drain.UnexpectedError, fmt.Errorf("failed to convert label selector")) | ||
| } | ||
|
|
||
| if pod.Namespace == pdb.Namespace && selector.Matches(labels.Set(pod.Labels)) && pdb.Status.DisruptionsAllowed < 1 { | ||
| return drainability.NewBlockedStatus(drain.NotEnoughPdb, fmt.Errorf("not enough pod disruption budget to move %s/%s", pod.Namespace, pod.Name)) | ||
| } | ||
| } | ||
| return drainability.NewUndefinedStatus() | ||
| } |
159 changes: 159 additions & 0 deletions
159
cluster-autoscaler/simulator/drainability/rules/pdb/pdb_test.go
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,159 @@ | ||
| /* | ||
| Copyright 2023 The Kubernetes Authors. | ||
| Licensed under the Apache License, Version 2.0 (the "License"); | ||
| you may not use this file except in compliance with the License. | ||
| You may obtain a copy of the License at | ||
| http://www.apache.org/licenses/LICENSE-2.0 | ||
| Unless required by applicable law or agreed to in writing, software | ||
| distributed under the License is distributed on an "AS IS" BASIS, | ||
| WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| See the License for the specific language governing permissions and | ||
| limitations under the License. | ||
| */ | ||
|
|
||
| package pdb | ||
|
|
||
| import ( | ||
| "testing" | ||
|
|
||
| apiv1 "k8s.io/api/core/v1" | ||
| policyv1 "k8s.io/api/policy/v1" | ||
| metav1 "k8s.io/apimachinery/pkg/apis/meta/v1" | ||
| "k8s.io/apimachinery/pkg/util/intstr" | ||
| "k8s.io/autoscaler/cluster-autoscaler/simulator/drainability" | ||
| "k8s.io/autoscaler/cluster-autoscaler/utils/drain" | ||
| ) | ||
|
|
||
| func TestMirrorPodRule(t *testing.T) { | ||
| one := intstr.FromInt(1) | ||
|
|
||
| testCases := []struct { | ||
| desc string | ||
| pod *apiv1.Pod | ||
| drainCtx *drainability.DrainContext | ||
| wantOutcome drainability.OutcomeType | ||
| wantReason drain.BlockingPodReason | ||
| }{ | ||
| { | ||
| desc: "no context", | ||
| pod: &apiv1.Pod{ | ||
| ObjectMeta: metav1.ObjectMeta{}, | ||
| }, | ||
| }, | ||
| { | ||
| desc: "no pdbs", | ||
| pod: &apiv1.Pod{}, | ||
| drainCtx: &drainability.DrainContext{}, | ||
| }, | ||
| { | ||
| desc: "no matching pdbs", | ||
| pod: &apiv1.Pod{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: "happy", | ||
| Namespace: "good", | ||
| Labels: map[string]string{ | ||
| "label": "true", | ||
| }, | ||
| }, | ||
| }, | ||
| drainCtx: &drainability.DrainContext{ | ||
| Pdbs: []*policyv1.PodDisruptionBudget{ | ||
| { | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Namespace: "bad", | ||
| }, | ||
| Spec: policyv1.PodDisruptionBudgetSpec{ | ||
| MinAvailable: &one, | ||
| Selector: &metav1.LabelSelector{ | ||
| MatchLabels: map[string]string{ | ||
| "label": "true", | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| { | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Namespace: "good", | ||
| }, | ||
| Spec: policyv1.PodDisruptionBudgetSpec{ | ||
| MinAvailable: &one, | ||
| Selector: &metav1.LabelSelector{ | ||
| MatchLabels: map[string]string{ | ||
| "label": "false", | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| { | ||
| desc: "pdb prevents scale-down", | ||
| pod: &apiv1.Pod{ | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: "sad", | ||
| Namespace: "good", | ||
| Labels: map[string]string{ | ||
| "label": "true", | ||
| }, | ||
| }, | ||
| }, | ||
| drainCtx: &drainability.DrainContext{ | ||
| Pdbs: []*policyv1.PodDisruptionBudget{ | ||
| { | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Namespace: "bad", | ||
| }, | ||
| Spec: policyv1.PodDisruptionBudgetSpec{ | ||
| MinAvailable: &one, | ||
| Selector: &metav1.LabelSelector{ | ||
| MatchLabels: map[string]string{ | ||
| "label": "true", | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| { | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Namespace: "good", | ||
| }, | ||
| Spec: policyv1.PodDisruptionBudgetSpec{ | ||
| MinAvailable: &one, | ||
| Selector: &metav1.LabelSelector{ | ||
| MatchLabels: map[string]string{ | ||
| "label": "true", | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| { | ||
| ObjectMeta: metav1.ObjectMeta{ | ||
| Namespace: "good", | ||
| }, | ||
| Spec: policyv1.PodDisruptionBudgetSpec{ | ||
| MinAvailable: &one, | ||
| Selector: &metav1.LabelSelector{ | ||
| MatchLabels: map[string]string{ | ||
| "label": "false", | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| }, | ||
| wantOutcome: drainability.BlockDrain, | ||
| wantReason: drain.NotEnoughPdb, | ||
| }, | ||
| } | ||
| for _, tc := range testCases { | ||
| t.Run(tc.desc, func(t *testing.T) { | ||
| got := New().Drainable(tc.drainCtx, tc.pod) | ||
| if got.Outcome != tc.wantOutcome || got.BlockingReason != tc.wantReason { | ||
| t.Errorf("Rule.Drainable(%s) = (outcome: %v, reason: %v), want (outcome: %v, reason: %v)", tc.pod.Name, got.Outcome, got.BlockingReason, tc.wantOutcome, tc.wantReason) | ||
| } | ||
| }) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters