Skip to content

Commit

Permalink
Update static_autoscaler tests & handle pod list processors errors as…
Browse files Browse the repository at this point in the history
… warnings
  • Loading branch information
atwamahmoud committed Nov 21, 2023
1 parent dead562 commit ba9b000
Show file tree
Hide file tree
Showing 2 changed files with 148 additions and 150 deletions.
6 changes: 5 additions & 1 deletion cluster-autoscaler/core/static_autoscaler.go
Original file line number Diff line number Diff line change
Expand Up @@ -506,7 +506,11 @@ func (a *StaticAutoscaler) RunOnce(currentTime time.Time) caerrors.AutoscalerErr
a.AutoscalingContext.DebuggingSnapshotter.SetClusterNodes(l)
}

unschedulablePodsToHelp, _ := a.processors.PodListProcessor.Process(a.AutoscalingContext, unschedulablePods)
unschedulablePodsToHelp, err := a.processors.PodListProcessor.Process(a.AutoscalingContext, unschedulablePods)

if err != nil {
klog.Warningf("Failed to process unschedulable pods: %v", err)
}

// finally, filter out pods that are too "young" to safely be considered for a scale-up (delay is configurable)
unschedulablePodsToHelp = a.filterOutYoungPods(unschedulablePodsToHelp, currentTime)
Expand Down
Loading

0 comments on commit ba9b000

Please sign in to comment.