Merge pull request #6611 from azylinski/fix-default-disk-type

Set "pd-balanced" as DefaultBootDiskType
kubernetes · Mar 13, 2024 · 601da3f · 601da3f
2 parents 3288160 + 7ee93b4
commit 601da3f
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/cluster-autoscaler/cloudprovider/gce/gce_price_info.go b/cluster-autoscaler/cloudprovider/gce/gce_price_info.go
@@ -546,8 +546,9 @@ var (
 		"pd-balanced": 0.100 / hoursInMonth,
 		"pd-ssd":      0.170 / hoursInMonth,
 	}
-	// DefaultBootDiskType is pd-standard disk type.
-	DefaultBootDiskType = "pd-standard"
+	// DefaultBootDiskType is pd-balanced disk type.
+	// ref: https://cloud.google.com/kubernetes-engine/docs/how-to/custom-boot-disks#specify
+	DefaultBootDiskType = "pd-balanced"
 )
 
 // GcePriceInfo is the GCE specific implementation of the PricingInfo.

diff --git a/cluster-autoscaler/cloudprovider/gce/gce_price_model_test.go b/cluster-autoscaler/cloudprovider/gce/gce_price_model_test.go
@@ -110,7 +110,7 @@ func TestGetNodePrice(t *testing.T) {
 		"custom node price scales linearly": {
 			cheaperNode:                testNode(t, "small_custom", "custom-1", 1000, 3.75*units.GiB, "", 0, false, false),
 			expensiveNode:              testNode(t, "large_custom", "custom-8", 8000, 30*units.GiB, "", 0, false, false),
-			priceComparisonCoefficient: 0.14,
+			priceComparisonCoefficient: 0.16,
 		},
 		"custom node price scales linearly 2": {
 			cheaperNode:                testNode(t, "large_custom", "custom-8", 8000, 30*units.GiB, "", 0, false, false),