Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update OWNERS file #69

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update OWNERS file #69

wants to merge 1 commit into from

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Dec 20, 2024

Fix: #67

let me know if that is correct or if need to add/remove
cc @BenTheElder @jberkus

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Dec 20, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cpanato
Once this PR has been reviewed and has the lgtm label, please assign katharine for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 20, 2024
@MadhavJivrajani
Copy link

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2024
jberkus
jberkus reviewed Dec 20, 2024
View reviewed changes
OWNERS_ALIASES
# See the OWNERS docs at https://go.k8s.io/owners

aliases:
slack-infra-approvers:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did @mrbobbytables opt out here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i can add him

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

@cpanato
update owners file
3028c72 
Signed-off-by: cpanato <[email protected]>
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 21, 2024
@cpanato cpanato requested a review from jberkus December 25, 2024 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeefy jeefy Awaiting requested review from jeefy

@Katharine Katharine Awaiting requested review from Katharine

@jberkus jberkus Awaiting requested review from jberkus

Assignees

@MadhavJivrajani MadhavJivrajani

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update OWNERS
4 participants
@cpanato @k8s-ci-robot @MadhavJivrajani @jberkus