Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add e2e-framework for kwok with kind #488

Merged
merged 1 commit into from
Sep 8, 2023
Merged

add e2e-framework for kwok with kind #488

merged 1 commit into from
Sep 8, 2023

Conversation

wwwnay
Copy link

@wwwnay wwwnay commented Apr 12, 2023 •
edited by wzshiming
Loading

What type of PR is this?

/kind feature

What this PR does / why we need it:

add e2e for kwok with kubernetes-sigs/e2e-framework

Which issue(s) this PR fixes:

Fixes #423

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 12, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 12, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @wwwnay. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@netlify
Copy link

netlify bot commented Apr 12, 2023 •
edited
Loading

✅ Deploy Preview for k8s-kwok canceled.

Name Link
🔨 Latest commit db886a9
🔍 Latest deploy log https://app.netlify.com/sites/k8s-kwok/deploys/64f179483fcffc0008077cd0

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Apr 12, 2023
@wzshiming
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 13, 2023
@wwwnay wwwnay force-pushed the add-e2eframework branch 4 times, most recently from ac393e3 to 54a0a6b Compare April 13, 2023 03:32
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 13, 2023
wzshiming
wzshiming requested changes Apr 13, 2023
View reviewed changes
.github/workflows/test.yaml Outdated Show resolved Hide resolved
test/helper/kindCluster.go Outdated Show resolved Hide resolved
test/helper/kustomize.go Outdated Show resolved Hide resolved
test/helper/kustomize.go Outdated Show resolved Hide resolved
test/helper/kindCluster.go Outdated Show resolved Hide resolved
test/helper/kindCluster.go Outdated Show resolved Hide resolved
@wwwnay wwwnay force-pushed the add-e2eframework branch 3 times, most recently from cea4768 to 06956ce Compare April 13, 2023 05:10
wzshiming
wzshiming reviewed Apr 13, 2023
View reviewed changes
Copy link
Member

@wzshiming wzshiming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move test/e2e/kwok/ and rebase to latest

test/e2e/kwok_test.go Outdated Show resolved Hide resolved
test/e2e/kind-config.yaml Outdated Show resolved Hide resolved
wzshiming
wzshiming reviewed Apr 13, 2023
View reviewed changes
test/e2e/main_test.go Outdated Show resolved Hide resolved
test/e2e/main_test.go Outdated Show resolved Hide resolved
test/e2e/main_test.go Outdated Show resolved Hide resolved
wzshiming
wzshiming reviewed Apr 13, 2023
View reviewed changes
test/e2e/main_test.go Outdated Show resolved Hide resolved
@wzshiming wzshiming force-pushed the add-e2eframework branch 2 times, most recently from c4ae2d4 to 74b0b8a Compare April 13, 2023 11:30
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 13, 2023
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 24, 2023
@wzshiming wzshiming force-pushed the add-e2eframework branch 3 times, most recently from db61dd3 to fd4f4bd Compare August 24, 2023 10:58
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Aug 24, 2023
@wzshiming wzshiming force-pushed the add-e2eframework branch 16 times, most recently from e09a40a to 4b8a988 Compare August 29, 2023 09:12
@wzshiming
Copy link
Member

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 8, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wwwnay, wzshiming

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2023
@k8s-ci-robot k8s-ci-robot merged commit e98a449 into kubernetes-sigs:main Sep 8, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wzshiming wzshiming wzshiming requested changes

@yibozhuang yibozhuang Awaiting requested review from yibozhuang

Assignees

@wzshiming wzshiming

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[test] Migration e2e using sigs.k8s.io/e2e-framework
4 participants
@wwwnay @k8s-ci-robot @wzshiming @k8s-triage-robot