Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ResourceFlavorReference for ResourceFlavor names #3611

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Use ResourceFlavorReference for ResourceFlavor names #3611

merged 1 commit into from
Nov 25, 2024

Conversation

kaisoz
Copy link
Contributor

@kaisoz kaisoz commented Nov 21, 2024

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

A ResourceFlavor name is referenced in different ways through the code, either as a ResourceFlavorReference or as a string. This PR ensures that only ResourceFlavorReference is used unless a cast to string is absolutely necessary.

Which issue(s) this PR fixes:

Fixes #3491

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Nov 21, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 21, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 21, 2024 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit d5a7bb7
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-kueue/deploys/674384266f05db00087ccac3

@mbobrovskyi
Copy link
Contributor

/lgtm
Awesome. Thanks!
As a follow-up, it would be nice to update the tests to use the .Ref() method.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fcf16510009eea9a1935d2da5e540d6c79faf1c0

@kaisoz
Copy link
Contributor Author

kaisoz commented Nov 22, 2024

/lgtm Awesome. Thanks! As a follow-up, it would be nice to update the tests to use the .Ref() method.

Thanks! 😊 I see that other reviewers have concerns on the method... what's your take on it? It feels that I should go with the cast to ResourceFlavorReference and then assess?

@mbobrovskyi
Copy link
Contributor

/lgtm Awesome. Thanks! As a follow-up, it would be nice to update the tests to use the .Ref() method.

Thanks! 😊 I see that other reviewers have concerns on the method... what's your take on it? It feels that I should go with the cast to ResourceFlavorReference and then assess?

Yes, please, cast to ResourceFlavorReference 🙏

@kaisoz kaisoz force-pushed the use-resourceflavorreference-consistently branch from 4a77f59 to 42f3577 Compare November 22, 2024 15:14
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 22, 2024
@kaisoz
Copy link
Contributor Author

kaisoz commented Nov 22, 2024

@mbobrovskyi @mimowo @tenzen-y changes added. PTAL 😊 Thanks for you time!

mbobrovskyi
mbobrovskyi reviewed Nov 22, 2024
View reviewed changes
pkg/controller/tas/resource_flavor.go Outdated Show resolved Hide resolved
cmd/importer/util/util.go Outdated Show resolved Hide resolved
@kaisoz kaisoz force-pushed the use-resourceflavorreference-consistently branch from 42f3577 to d5a7bb7 Compare November 24, 2024 19:53
mbobrovskyi
mbobrovskyi approved these changes Nov 25, 2024
View reviewed changes
Copy link
Contributor

@mbobrovskyi mbobrovskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
Thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 980904c03b4118e6f9b24b8543eacd2a7b33eade

@mimowo
Copy link
Contributor

mimowo commented Nov 25, 2024

/approve
Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaisoz, mbobrovskyi, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit d13068b into kubernetes-sigs:main Nov 25, 2024
16 of 17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.10 milestone Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mimowo mimowo mimowo left review comments

@mbobrovskyi mbobrovskyi mbobrovskyi approved these changes

@denkensk denkensk Awaiting requested review from denkensk

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

Assignees

@mbobrovskyi mbobrovskyi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v0.10
Development

Successfully merging this pull request may close these issues.

Use ResourceFlavorReference instead of string consistently
5 participants
@kaisoz @mbobrovskyi @k8s-ci-robot @mimowo @tenzen-y