fix nil dereference

kubernetes-sigs · Mar 20, 2024 · 7ce7043 · 7ce7043
1 parent 56b7fb7
commit 7ce7043
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/api/jobset/v1alpha2/jobset_webhook.go b/api/jobset/v1alpha2/jobset_webhook.go
@@ -149,11 +149,11 @@ func (js *JobSet) ValidateCreate() (admission.Warnings, error) {
 		}
 
 		// Validate Job template spec.
-		var u *unstructured.Unstructured
-		if err := convertObj2Unstructured(rjob.Template, u); err != nil {
+		var u unstructured.Unstructured
+		if err := convertObj2Unstructured(rjob.Template, &u); err != nil {
 			return nil, fmt.Errorf("error converting to unstructured: %v", err)
 		}
-		if err := v.Validate(u); err != nil {
+		if err := v.Validate(&u); err != nil {
 			allErrs = append(allErrs, err)
 		}