Merge pull request #171 from dgrisonnet/disable-pnf

Disable priority and fairness by default
kubernetes-sigs · Apr 25, 2024 · 1a855fe · 1a855fe
2 parents 4f8ac35 + 5255168
commit 1a855fe
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 8 deletions.
diff --git a/pkg/cmd/options/options.go b/pkg/cmd/options/options.go
@@ -58,6 +58,10 @@ func NewCustomMetricsAdapterServerOptions() *CustomMetricsAdapterServerOptions {
 		EnableMetrics: true,
 	}
 
+	// Explicitly disable Priority and Fairness since metric servers are not
+	// meant to be queried directly by default.
+	o.Features.EnablePriorityAndFairness = false
+
 	return o
 }
 

diff --git a/test-adapter-deploy/testing-adapter.yaml b/test-adapter-deploy/testing-adapter.yaml
@@ -176,14 +176,6 @@ rules:
   verbs:
   - get
   - list
-- apiGroups:
-  - flowcontrol.apiserver.k8s.io
-  resources:
-  - prioritylevelconfigurations
-  - flowschemas
-  verbs:
-  - list
-  - watch
 ---
 apiVersion: rbac.authorization.k8s.io/v1
 kind: ClusterRoleBinding