Trim license patch from version tag, bump list to v3.24.0 #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/bug
Signed-off-by: Adolfo García Veytia (puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (puerco) <[email protected]>
Signed-off-by: Adolfo García Veytia (puerco) <[email protected]>
cpanato
approved these changes
Jul 27, 2024
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, puerco The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
/kind cleanup
/kind failing-test
What this PR does / why we need it:
This PR trims the patch version from the SPDX license list datafile before writing it to the SBOM to fix a bug has kept our CI broken for months
This is because there was a change in the versioning scheme, the SPDX license now is released with a full semver with a patch while the spec only supports major.minor
This change modifies the logic when writing the document to parse out the patch from the version tag and make the documents compliant again. The downside is that we will never know exactly which license list version was used to generate the sbom but I don't think there is any way around it.
Which issue(s) this PR fixes:
Fixes the broken CI jobs
Special notes for your reviewer:
Ref: spdx/LicenseListPublisher#181
/cc @cpanato @saschagrunert @xmudrii @Verolop
Does this PR introduce a user-facing change?