-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update go version to fix tests #560
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: TerryHowe The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Welcome @TerryHowe! |
Hi @TerryHowe. Thanks for your PR. I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@xing-yang would you be able to help with an ok-to-test here? :) |
/ok-to-test |
Hmm, looks like the prow jobs are still running with Go 1.19, this failing with the newer directive:
|
The repo's version of release-tools is out of date. Current release-tools points to Go 1.22.5. https://github.com/kubernetes-csi/csi-release-tools/blob/master/prow.sh#L89 Local copy still points to an older version using 1.19: https://github.com/kubernetes-csi/csi-test/blob/master/release-tools/prow.sh#L89 |
Fixed |
I think we'll need a full update like #431. It's an unfortunate circular dependency between the tools used to test and the tools used to release. :/ |
I'll take a look at it later and see if I can make sense of it. |
@TerryHowe: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
I think this will be depent upon |
|
What type of PR is this?
/kind failing-test
csi-release-test failing tests
What this PR does / why we need it:
Should fix
kubernetes-csi/csi-release-tools#259
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
May require:
kubernetes-csi/csi-release-tools#260
Does this PR introduce a user-facing change?:
No