Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google-auth Made as optional dependency #2294

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

shivanand007
Copy link

@shivanand007 shivanand007 commented Oct 8, 2024

What type of PR is this?

/kind feature

What this PR does / why we need it:

Makes Google auth as optional dependency, gives users a option to install it separately.

Which issue(s) this PR fixes:

Fixes #2249

Special notes for your reviewer:

Does this PR introduce a user-facing change?

This change modifies the `setup.py` file to move `google-auth` to the `extras_require` section,
allowing it to be installed with `pip install kubernetes[google-auth]`.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:


@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Oct 8, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shivanand007
Once this PR has been reviewed and has the lgtm label, please assign roycaihw for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 8, 2024
Copy link
Member

@roycaihw roycaihw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a release note with instructions of how to install google-auth going forward.

We should also make sure the tests pass. I wonder if we need to update the test pipeline to install google-auth as well.

/retest

setup.py Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Oct 9, 2024
@shivanand007
Copy link
Author

shivanand007 commented Oct 9, 2024

Please add a release note with instructions of how to install google-auth going forward.

--> I have added the required release note, kindly have a review for the same.

We should also make sure the tests pass. I wonder if we need to update the test pipeline to install google-auth as well.

--> Yes, As we have Removed google-auth from requirements.txt, This must be a dependency in code which makes test cases to fail, I will check the code and see if we can make those code blocks optional as well, Additionally we have to update the test pipeline to test this use case.

/retest

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 9, 2024
@shivanand007
Copy link
Author

@roycaihw
I have made the necessary changes in code to make google-auth as optional, Requesting to Change Test Pipeline, So That we can pass all the E2E test Cases.

@shivanand007
Copy link
Author

/retest

@k8s-ci-robot
Copy link
Contributor

@shivanand007: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make google-auth an optional dependency
3 participants