-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
google-auth Made as optional dependency #2294
base: master
Are you sure you want to change the base?
google-auth Made as optional dependency #2294
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: shivanand007 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a release note with instructions of how to install google-auth going forward.
We should also make sure the tests pass. I wonder if we need to update the test pipeline to install google-auth as well.
/retest
--> I have added the required release note, kindly have a review for the same.
--> Yes, As we have Removed google-auth from requirements.txt, This must be a dependency in code which makes test cases to fail, I will check the code and see if we can make those code blocks optional as well, Additionally we have to update the test pipeline to test this use case.
|
…f google_auth is installed.
@roycaihw |
/retest |
@shivanand007: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Makes Google auth as optional dependency, gives users a option to install it separately.
Which issue(s) this PR fixes:
Fixes #2249
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: