Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSI driver for VMware Cloud Director #2092

Merged
merged 5 commits into from
Jun 8, 2022
Merged

Add CSI driver for VMware Cloud Director #2092

merged 5 commits into from
Jun 8, 2022

Conversation

ahmedwaleedmalik
Copy link
Member

@ahmedwaleedmalik ahmedwaleedmalik commented Jun 7, 2022 •
edited
Loading

Signed-off-by: Waleed Malik [email protected]

What type of PR is this?

/kind feature

What this PR does / why we need it:
Add the VMware Cloud Director CSI driver addon.

They don't have the support for snapshots yet vmware/cloud-director-named-disk-csi-driver#28

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1991

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

* Add the VMware Cloud Director CSI driver addon. 
* Add default StorageClass for the VMware Cloud Director CSI driver.

@ahmedwaleedmalik ahmedwaleedmalik self-assigned this Jun 7, 2022
@kubermatic-bot kubermatic-bot added kind/feature Categorizes issue or PR as related to a new feature. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Jun 7, 2022
@kubermatic-bot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kubermatic-bot kubermatic-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 7, 2022
@ahmedwaleedmalik ahmedwaleedmalik marked this pull request as ready for review June 7, 2022 11:27
@kubermatic-bot kubermatic-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 7, 2022
@kubermatic-bot kubermatic-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 7, 2022
@ahmedwaleedmalik
Copy link
Member Author

/retest

@ahmedwaleedmalik
Update generated code
6817def 
Signed-off-by: Waleed Malik <[email protected]>
@ahmedwaleedmalik ahmedwaleedmalik requested a review from kron4eg June 7, 2022 15:26
kron4eg
kron4eg reviewed Jun 7, 2022
View reviewed changes
pkg/terraform/v1beta2/config.go
if len(cp.VAppName) > 0 {
cluster.CloudProvider.VMwareCloudDirector.VApp = cp.VAppName
} else {
cluster.CloudProvider.VMwareCloudDirector.VApp = cluster.Name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This logic should be part of the defaulting process.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umm, are you referring to https://github.com/kubermatic/kubeone/blob/master/pkg/apis/kubeone/v1beta2/defaults.go#L47? This defaulting here is based on the terraform output. Just like https://github.com/kubermatic/kubeone/blob/master/pkg/terraform/v1beta2/config.go#L263

@ahmedwaleedmalik
Refactored code
09b3752 
Signed-off-by: Waleed Malik <[email protected]>
@ahmedwaleedmalik
Copy link
Member Author

/retest
flake

@ahmedwaleedmalik ahmedwaleedmalik requested a review from kron4eg June 8, 2022 08:51
@kron4eg
Copy link
Member

kron4eg commented Jun 8, 2022

/approve
/lgtm

@kubermatic-bot kubermatic-bot added the lgtm Indicates that a PR is ready to be merged. label Jun 8, 2022
@kubermatic-bot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ec1097a365905c8bfd0c8a7a1c09bea87024a5ff

@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kron4eg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 8, 2022
@kubermatic-bot kubermatic-bot merged commit 5b5e9d7 into kubermatic:master Jun 8, 2022
@kubermatic-bot kubermatic-bot added this to the KubeOne 1.5 milestone Jun 8, 2022
@ahmedwaleedmalik ahmedwaleedmalik deleted the csi-vmware-cloud-director branch June 9, 2022 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kron4eg kron4eg Awaiting requested review from kron4eg

Assignees

@kron4eg kron4eg

@ahmedwaleedmalik ahmedwaleedmalik

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
KubeOne 1.5
Development

Successfully merging this pull request may close these issues.

CSI driver for VMware Cloud Director
3 participants
@ahmedwaleedmalik @kubermatic-bot @kron4eg