Fix for out of date thumbnails #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this edit I've tried to fix an issue where thumbnails in the built site are out of date.
The previous behaviour was to only copy thumbnails to the build directory in the
after_buildfunction if the thumbnail did not exist. However, it is possible that this thumbnail is out of date (if the original image has been updated).In the fix, I now check also if
cached_thumbnail_available?. This will return false if there is no cached thumbnail (or if the current cached thumbnail is out of date). In this occurs (or if the thumbnail does not exist) we should copy the thumbnail (after creating a new cached version, which happens with thesave!method.