-
Notifications
You must be signed in to change notification settings - Fork 780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notebooks: Rename "Notebook" to "Workbench" in web documentation #3530
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Hi @tzstoyanov. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
464d106
to
d3e9d17
Compare
/hold until we discuss these changes in the notebooks wg. |
/remove-hold |
d3e9d17
to
d504e95
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: tzstoyanov The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d504e95
to
74bf165
Compare
@juliusvonkohout @tzstoyanov I strongly believe that we should NOT do a rename unless there is a technical change, as that would just be confusing to users who already know about "Kubeflow Notebooks", which is effectively a brand at this point rather than a description. /hold |
62df3ab
to
16d8d80
Compare
Kubeflow notebooks were initially created from JupyterLab Notebook. That functionality evolved, now other web-based development environments can be used as well - VSCode, RStudio and others can be added in future. The term "notebook" is a bit misleading and does not reflect all recent changes and enhancements. That's why a proposal was made to replace it with the term "workbench" - issue 6981. This patch renames "notebook" to "workbench" in the Kubeflow web documentation. issue: kubeflow/kubeflow#6981 Signed-off-by: Tzvetomir Stoyanov (VMware) <[email protected]>
16d8d80
to
95ca23f
Compare
@thesuperzapper @juliusvonkohout @tzstoyanov can you provide an update on this PR? |
@varodrig yep, especially with the Notebooks 2.0 work we will eventually use the term "Kubeflow Workspaces", after a few releases, but may never fully drop the "Kubeflow Notebooks" branding given its industry prevalence. /close |
@thesuperzapper: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Kubeflow notebooks were initially created from JupyterLab Notebook. That functionality evolved, now other web-based development environments can be used as well - VSCode, RStudio and others can be added in future. The term "notebook" is a bit misleading and does not reflect all recent changes and enhancements. That's why a proposal was made to replace it with the term "workbench" - issue 6981.
This patch renames "notebook" to "workbench" in the Kubeflow web documentation.
issue: kubeflow/kubeflow#6981