Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notebooks: Rename "Notebook" to "Workbench" in web documentation #3530

Closed
wants to merge 1 commit into from

Conversation

tzstoyanov
Copy link

Kubeflow notebooks were initially created from JupyterLab Notebook. That functionality evolved, now other web-based development environments can be used as well - VSCode, RStudio and others can be added in future. The term "notebook" is a bit misleading and does not reflect all recent changes and enhancements. That's why a proposal was made to replace it with the term "workbench" - issue 6981.
This patch renames "notebook" to "workbench" in the Kubeflow web documentation.

issue: kubeflow/kubeflow#6981

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@google-oss-prow
Copy link

Hi @tzstoyanov. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@tzstoyanov
Copy link
Author

tzstoyanov commented Jun 21, 2023

/hold until we discuss these changes in the notebooks wg.

@tzstoyanov
Copy link
Author

/remove-hold

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tzstoyanov
Once this PR has been reviewed and has the lgtm label, please assign zijianjoy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thesuperzapper
Copy link
Member

@juliusvonkohout @tzstoyanov I strongly believe that we should NOT do a rename unless there is a technical change, as that would just be confusing to users who already know about "Kubeflow Notebooks", which is effectively a brand at this point rather than a description.

/hold

@tzstoyanov tzstoyanov force-pushed the note-rename-web branch 5 times, most recently from 62df3ab to 16d8d80 Compare July 21, 2023 07:51
Kubeflow notebooks were initially created from JupyterLab Notebook. That
functionality evolved, now other web-based development environments can
be used as well - VSCode, RStudio and others can be added in future. The
term "notebook" is a bit misleading and does not reflect all recent
changes and enhancements. That's why a proposal was made to replace it
with the term "workbench" - issue 6981.
This patch renames "notebook" to "workbench" in the Kubeflow web
documentation.

issue: kubeflow/kubeflow#6981
Signed-off-by: Tzvetomir Stoyanov (VMware) <[email protected]>
@varodrig
Copy link
Contributor

@thesuperzapper @juliusvonkohout @tzstoyanov can you provide an update on this PR?
should we close it?

@thesuperzapper
Copy link
Member

@thesuperzapper @juliusvonkohout @tzstoyanov can you provide an update on this PR? should we close it?

@varodrig yep, especially with the Notebooks 2.0 work we will eventually use the term "Kubeflow Workspaces", after a few releases, but may never fully drop the "Kubeflow Notebooks" branding given its industry prevalence.

/close

Copy link

@thesuperzapper: Closed this PR.

In response to this:

@thesuperzapper @juliusvonkohout @tzstoyanov can you provide an update on this PR? should we close it?

@varodrig yep, especially with the Notebooks 2.0 work we will eventually use the term "Kubeflow Workspaces", after a few releases, but may never fully drop the "Kubeflow Notebooks" branding given its industry prevalence.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@google-oss-prow google-oss-prow bot closed this Dec 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants