Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile with python debian image in cmd/initializer_v2/dataset/Dockerfile #2312

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mani1soni
Copy link

Updated Dockerfile with python debian image for resolving issue :- "Use Debian images for Python components in the Training Operator V2 #2311" in this dockerfile - cmd/initializer_v2/dataset/Dockerfile

What this PR does / why we need it: This PR replaces the docker image from "python:3.11-alpine" to "python:3.11-slim-bookworm". As per the comment #2303.

Which issue(s) this PR fixes This PR Fixes #2311 issue.

Updated Dockerfile with python debian image for resolving issue :- "Use Debian images for Python components in the Training Operator V2 kubeflow#2311"

Signed-off-by: Manish Soni <[email protected]>
Update Dockerfile with python debian image
@coveralls
Copy link

Pull Request Test Coverage Report for Build 11554548437

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 11542660312: 0.0%
Covered Lines: 77
Relevant Lines: 77

💛 - Coveralls

Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution!
/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andreyvelich
Copy link
Member

/hold

@andreyvelich
Copy link
Member

@mani1soni Thank you for this!
Please can you also update the model initializer script and verify locally that this images is working with HF snapshot download API ?

@mani1soni
Copy link
Author

@mani1soni Thank you for this! Please can you also update the model initializer script and verify locally that this images is working with HF snapshot download API ?

Sure @andreyvelich, I'll check that.

@andreyvelich
Copy link
Member

Hi @mani1soni, did you get a chance to update the rest Docker images ?

@mani1soni
Copy link
Author

Hi @mani1soni, did you get a chance to update the rest Docker images ?

Hi @andreyvelich , I checked them. I’ll update the code by tomorrow. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use Debian images for Python components in the Training Operator V2
4 participants