Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDK] test: added unit tests for delete_job() method #2202

Closed
wants to merge 1 commit into from

Conversation

Bobbins228
Copy link
Contributor

What this PR does / why we need it:
Added unit tests for the training_client.delete_job() method
Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Ref #2161

Checklist:

  • Docs included if any changes are user facing

Copy link

google-cla bot commented Aug 12, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jinchihe for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobbins228 Bobbins228 changed the title test: added unit tests for delete_job() method [SDK] test: added unit tests for delete_job() method Aug 12, 2024
@Bobbins228 Bobbins228 force-pushed the unit-test-delete-job branch from 21dedf1 to 92ebe28 Compare August 12, 2024 11:56
@Bobbins228 Bobbins228 force-pushed the unit-test-delete-job branch from 92ebe28 to e7b96fa Compare August 12, 2024 13:08
@Bobbins228
Copy link
Contributor Author

Hey @jinchihe,

Are you able to re-run the Google CLA check? It should work now :)

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andreyvelich
Copy link
Member

@Bobbins228 We fixed the issue with Google CLA, please can you open a new PR with your change ?
Sorry for that!

@Bobbins228
Copy link
Contributor Author

No worries @andreyvelich new PR incoming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants