-
Notifications
You must be signed in to change notification settings - Fork 708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] test: added unit tests for delete_job() method #2202
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
21dedf1
to
92ebe28
Compare
Signed-off-by: Bobbins228 <[email protected]>
92ebe28
to
e7b96fa
Compare
Hey @jinchihe, Are you able to re-run the Google CLA check? It should work now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CLA check should not be here. https://github.com/kubeflow/community/blob/master/ksc/decision-log.md#switch-from-google-cla-to-dco
We are looking into this. cc @andreyvelich @james-jwu @zijianjoy
@Bobbins228 We fixed the issue with Google CLA, please can you open a new PR with your change ? |
No worries @andreyvelich new PR incoming! |
What this PR does / why we need it:
Added unit tests for the
training_client.delete_job()
methodWhich issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Ref #2161
Checklist: