Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance pre-commit hooks with flake8 linting #2195

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

Ygnas
Copy link
Contributor

@Ygnas Ygnas commented Aug 6, 2024

What this PR does / why we need it:
This PR implements the flake8 linter as a pre-commit hook to ensure code quality and adherence to style guidelines. It also addresses and fixes the issues identified by flake8.

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #1910

Checklist:

  • Docs included if any changes are user facing

Ygnas added 2 commits August 6, 2024 10:21
Signed-off-by: Ignas Baranauskas <[email protected]>
Signed-off-by: Ignas Baranauskas <[email protected]>
Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for adding this @Ygnas!

It would be nice to add it for Katib as well: https://github.com/kubeflow/katib/blob/master/.pre-commit-config.yaml.

/lgtm
/assign @droctothorpe

Copy link
Contributor

@droctothorpe droctothorpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job, @Ygnas! I freaking love pre-commit.

@droctothorpe
Copy link
Contributor

/lgtm

@droctothorpe
Copy link
Contributor

/approve

@andreyvelich
Copy link
Member

/rerun-all

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10263855792

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 33.486%

Totals Coverage Status
Change from base Build 10252995442: 0.02%
Covered Lines: 3950
Relevant Lines: 11796

💛 - Coveralls

@andreyvelich
Copy link
Member

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andreyvelich, droctothorpe

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit ff19a10 into kubeflow:master Aug 12, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Linter and Formatter for Python Files in CI/CD
4 participants