-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance pre-commit hooks with flake8 linting #2195
Conversation
Signed-off-by: Ignas Baranauskas <[email protected]>
Signed-off-by: Ignas Baranauskas <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this @Ygnas!
It would be nice to add it for Katib as well: https://github.com/kubeflow/katib/blob/master/.pre-commit-config.yaml.
/lgtm
/assign @droctothorpe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Great job, @Ygnas! I freaking love pre-commit.
/lgtm |
/approve |
/rerun-all |
Pull Request Test Coverage Report for Build 10263855792Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich, droctothorpe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR implements the flake8 linter as a pre-commit hook to ensure code quality and adherence to style guidelines. It also addresses and fixes the issues identified by flake8.
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...
format, will close the issue(s) when PR gets merged):Fixes #1910
Checklist: