Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry pick: [SDK] Sync Transformers version for train API (#2146) #2147

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Cherry pick: [SDK] Sync Transformers version for train API (#2146) #2147

merged 1 commit into from
Jun 14, 2024

Conversation

andreyvelich
Copy link
Member

Cherry pick this fix to the release branch: #2146

/assign @tenzen-y @johnugeorge

@google-oss-prow google-oss-prow bot requested review from jinchihe and kuizhiqing June 14, 2024 14:42
@coveralls
Copy link

coveralls commented Jun 14, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9517984735

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.03%) to 35.431%
Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/mpi/mpijob.go 1 91.06%
Totals Coverage Status
Change from base Build 9448871118: 0.03%
Covered Lines: 4381
Relevant Lines: 12365
💛 - Coveralls

tenzen-y
tenzen-y reviewed Jun 14, 2024
View reviewed changes
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Jun 14, 2024
@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 599b7e0 into kubeflow:v1.8-branch Jun 14, 2024
39 checks passed
@andreyvelich andreyvelich deleted the v1.8-branch branch June 14, 2024 15:19
@andreyvelich andreyvelich restored the v1.8-branch branch June 14, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tenzen-y tenzen-y tenzen-y left review comments

@jinchihe jinchihe Awaiting requested review from jinchihe

@kuizhiqing kuizhiqing Awaiting requested review from kuizhiqing

Assignees

@johnugeorge johnugeorge

@tenzen-y tenzen-y

Labels
approved lgtm size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andreyvelich @coveralls @tenzen-y @johnugeorge