Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] debug #1905

Closed
wants to merge 1 commit into from
Closed

[DO NOT MERGE] debug #1905

wants to merge 1 commit into from

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Sep 7, 2023

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in Fixes #<issue number>, #<issue number>, ... format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Yuki Iwai <[email protected]>
@coveralls
Copy link

coveralls commented Sep 8, 2023

Pull Request Test Coverage Report for Build 6125433423

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 42.77%

Files with Coverage Reduction New Missed Lines %
pkg/controller.v1/tensorflow/tfjob_controller.go 4 75.27%
pkg/controller.v1/mpi/mpijob_controller.go 8 80.48%
Totals Coverage Status
Change from base Build 6125431529: -0.1%
Covered Lines: 3736
Relevant Lines: 8735

💛 - Coveralls

@andreyvelich
Copy link
Member

@tenzen-y Any ideas why MXNet example could fail during our E2E ?
I tested locally, and it also stuck in Running state.

@tenzen-y
Copy link
Member Author

@tenzen-y Any ideas why MXNet example could fail during our E2E ? I tested locally, and it also stuck in Running state.

Have you seen the failure in the master branch as well?

@andreyvelich
Copy link
Member

@tenzen-y Any ideas why MXNet example could fail during our E2E ? I tested locally, and it also stuck in Running state.

Have you seen the failure in the master branch as well?

I think so, let me try to rebase my PR.

@tenzen-y tenzen-y closed this Sep 21, 2023
@tenzen-y tenzen-y deleted the debug branch September 21, 2023 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants