Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Yuki to Approvers #1901

Merged
merged 11 commits into from
Sep 6, 2023
Merged

Conversation

johnugeorge
Copy link
Member

I am recommending Yuki to be in the Training operator approvers list. He has met all the requirements for being an approver based on https://github.com/kubeflow/community/blob/master/wgs/community-membership.md#requirements-2

Reviewer of the codebase for at least 3 months: Yes
Primary reviewer for at least 10 substantial PRs to the codebase: Yes
Reviewed or merged at least 30 PRs to the codebase: 108
Reviewed PRs: https://github.com/kubeflow/training-operator/pulls?q=is%3Apr+-author%3Atenzen-y+reviewed-by%3A%40me+is%3Aclosed
Merged PRs: https://github.com/kubeflow/training-operator/pulls?q=is%3Apr+author%3Atenzen-y+is%3Aclosed

/assign @kubeflow/wg-training-leads

/hold

Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1.

@google-oss-prow
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge, terrytangyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [johnugeorge,terrytangyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your great contributions @tenzen-y!
/lgtm

OWNERS Outdated Show resolved Hide resolved
@gaocegege
Copy link
Member

Thank you for your great contributions @tenzen-y!
/lgtm

@google-oss-prow google-oss-prow bot removed the lgtm label Sep 5, 2023
@terrytangyuan
Copy link
Member

Awesome contributions! Fully support this.

@johnugeorge
Copy link
Member Author

Thanks everyone. Sorted alphabetically

OWNERS Outdated Show resolved Hide resolved
Copy link
Member

@kuizhiqing kuizhiqing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, @tenzen-y

@johnugeorge
Copy link
Member Author

Awesome contributions @tenzen-y Thanks for leading the community.
/lgtm

@johnugeorge
Copy link
Member Author

/hold cancel

@kubeflow kubeflow deleted a comment from google-oss-prow bot Sep 6, 2023
@johnugeorge
Copy link
Member Author

@terrytangyuan @gaocegege @andreyvelich Can you give a lgtm again?

@terrytangyuan
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Sep 6, 2023
@google-oss-prow google-oss-prow bot merged commit 12eefea into kubeflow:master Sep 6, 2023
24 checks passed
@tenzen-y
Copy link
Member

tenzen-y commented Sep 6, 2023

Thanks community!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants