-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Yuki to Approvers #1901
Adding Yuki to Approvers #1901
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge, terrytangyuan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your great contributions @tenzen-y!
/lgtm
Thank you for your great contributions @tenzen-y! |
Awesome contributions! Fully support this. |
Thanks everyone. Sorted alphabetically |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, @tenzen-y
Awesome contributions @tenzen-y Thanks for leading the community. |
/hold cancel |
@terrytangyuan @gaocegege @andreyvelich Can you give a lgtm again? |
/lgtm |
Thanks community! |
I am recommending Yuki to be in the Training operator approvers list. He has met all the requirements for being an approver based on https://github.com/kubeflow/community/blob/master/wgs/community-membership.md#requirements-2
Reviewer of the codebase for at least 3 months: Yes
Primary reviewer for at least 10 substantial PRs to the codebase: Yes
Reviewed or merged at least 30 PRs to the codebase: 108
Reviewed PRs: https://github.com/kubeflow/training-operator/pulls?q=is%3Apr+-author%3Atenzen-y+reviewed-by%3A%40me+is%3Aclosed
Merged PRs: https://github.com/kubeflow/training-operator/pulls?q=is%3Apr+author%3Atenzen-y+is%3Aclosed
/assign @kubeflow/wg-training-leads
/hold