Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing assignment of service-account for launcher #1898

Closed
wants to merge 12 commits into from
Closed

Removing assignment of service-account for launcher #1898

Changes from 7 commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c26fbe2
Removing assignment of service-account for launcher
rpemsel Sep 4, 2023
8c42234
Removing assignment of service-account for launcher
rpemsel Sep 4, 2023
8783adc
Merge remote-tracking branch 'origin/launcher-service-account' into l…
robert-ulbrich-mercedes-benz Sep 8, 2023
337f809
Increasing timeout in order to avoid e2e test failures
rpemsel Sep 11, 2023
a071eea
Extending maximum runtime of integration tests
rpemsel Sep 14, 2023
fc21a95
Merge branch 'kubeflow:master' into launcher-service-account
rpemsel Sep 19, 2023
4de96e7
Resetting timeout values for E2E tests
rpemsel Sep 19, 2023
e0976ee
Using service account name if provided, otherwise create default
Sep 20, 2023
933e428
Resetting timeout values for E2E tests
rpemsel Sep 19, 2023
4aa63c5
Merge branch 'launcher-service-account' of https://github.com/rpemsel…
Sep 20, 2023
e3ca98c
Using service account name if provided, otherwise create default
rpemsel Sep 20, 2023
bdd4b22
Merge branch 'launcher-service-account' of https://github.com/rpemsel…
Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion pkg/controller.v1/mpi/mpijob_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1035,7 +1035,6 @@ func (jc *MPIJobReconciler) newLauncher(mpiJob *kubeflowv1.MPIJob, kubectlDelive
jc.PodGroupControl.DecoratePodTemplateSpec(podSpec, mpiJob, rt)
}

podSpec.Spec.ServiceAccountName = launcherName
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried to build Training Operator image with your change and MPIJob test failed for me:

pytest sdk/python/test/e2e/test_e2e_mpijob.py --log-cli-level=info --namespace=default -k "test_sdk_e2e"

I think, we can't just remove SA assignment for MPIJob launcher.
MPIJob launcher requires the appropriate RBAC to exec and access MPIJob worker pods.
Thus, we attach the created ServiceAccount to MPIJob launcher.

MPI Operator experts can comment on this @alculquicondor @tenzen-y @terrytangyuan

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't sound right to remove the SA.

That said, we got rid of it in v2, because we don't use kubectl exec

podSpec.Spec.InitContainers = append(podSpec.Spec.InitContainers, corev1.Container{
Name: kubectlDeliveryName,
Image: kubectlDeliveryImage,
Expand Down
Loading