Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linter and Formatter for Python Files in CI/CD #1910

Closed
andreyvelich opened this issue Sep 12, 2023 · 6 comments · Fixed by #2195
Closed

Add Linter and Formatter for Python Files in CI/CD #1910

andreyvelich opened this issue Sep 12, 2023 · 6 comments · Fixed by #2195

Comments

@andreyvelich
Copy link
Member

andreyvelich commented Sep 12, 2023

As we discussed here: #1907 (comment), we need to add script to our CI/CD that uses black and flake8 to verify Python files.

Similar to our checks for Go: https://github.com/kubeflow/training-operator/blob/master/.github/workflows/test-go.yaml#L32.

/help

@google-oss-prow
Copy link

@andreyvelich:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

As we discussed here: #1907 (comment), we need to add script to our CI/CD that uses black and flake8 to verify Python files.

Similar to our checks for Go: https://github.com/kubeflow/training-operator/blob/master/.github/workflows/test-go.yaml#L32.

/help
/good first issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andreyvelich
Copy link
Member Author

/good-first-issue

@google-oss-prow
Copy link

@andreyvelich:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@tenzen-y
Copy link
Member

/lifecycle frozen

@sandipanpanda
Copy link
Member

I want to work on this.
/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment