Always update TrainJob status on errors

Signed-off-by: Antonin Stefanutti <[email protected]>
kubeflow · Dec 13, 2024 · f1839e6 · f1839e6
1 parent 01fd1b7
commit f1839e6
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/pkg/controller.v2/trainjob_controller.go b/pkg/controller.v2/trainjob_controller.go
@@ -94,7 +94,7 @@ func (r *TrainJobReconciler) Reconcile(ctx context.Context, req ctrl.Request) (c
 	setSuspendedCondition(&trainJob)
 	setCreatedCondition(&trainJob, opState)
 	if terminalCondErr := setTerminalCondition(ctx, runtime, &trainJob); terminalCondErr != nil {
-		return ctrl.Result{}, errors.Join(err, terminalCondErr)
+		err = errors.Join(err, terminalCondErr)
 	}
 	if !equality.Semantic.DeepEqual(&trainJob.Status, originStatus) {
 		return ctrl.Result{}, errors.Join(err, r.client.Status().Update(ctx, &trainJob))