Fix type for lora_dropout

Signed-off-by: Andrey Velichkevich <[email protected]>
kubeflow · Nov 28, 2024 · dd3a7a6 · dd3a7a6
1 parent ea3eb15
commit dd3a7a6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/hack/python-sdk-v2/gen-sdk.sh b/hack/python-sdk-v2/gen-sdk.sh
@@ -54,11 +54,7 @@ git clean -f ${SDK_OUTPUT_PATH}/setup.py
 git clean -f ${SDK_OUTPUT_PATH}/test-requirements.txt
 git clean -f ${SDK_OUTPUT_PATH}/tox.ini
 
-<<<<<<< HEAD
 # Revert the README since it is manually created.
-=======
-# Revert files that are manually created.
->>>>>>> f921bbe5 (Using global prop to remove SDK tests)
 git checkout ${SDK_OUTPUT_PATH}/README.md
 git checkout ${SDK_OUTPUT_PATH}/kubeflow/training/__init__.py
 

diff --git a/sdk_v2/kubeflow/training/types/types.py b/sdk_v2/kubeflow/training/types/types.py
@@ -56,7 +56,9 @@ class LoraConfig:
         default=None, metadata={"help": "Lora attention dimension"}
     )
     lora_alpha: Optional[int] = field(default=None, metadata={"help": "Lora alpha"})
-    lora_dropout: Optional[int] = field(default=None, metadata={"help": "Lora dropout"})
+    lora_dropout: Optional[float] = field(
+        default=None, metadata={"help": "Lora dropout"}
+    )
 
 
 @dataclass