Skip to content

Commit

Permalink
Rename Completed to Complete
Browse files Browse the repository at this point in the history
Signed-off-by: Yuki Iwai <[email protected]>
  • Loading branch information
tenzen-y committed Nov 2, 2024
1 parent 1cca202 commit 58d8587
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions docs/proposals/2170-kubeflow-training-v2/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ const (
TrainJobSuspended string = "Suspended"

// TrainJobCompleted means that the TrainJob has completed its execution.
TrainJobCompleted string = "Completed"
TrainJobCompleted string = "Complete"

// TrainJobFailed means that the actual jobs have failed its execution.
TrainJobFailed string = "Failed"
Expand Down Expand Up @@ -958,7 +958,7 @@ spec:
In this section, we're explaining the TrainJob state transition (`.status.conditions`).
The basic TrainJob state machine is the below.
Especially, if we specify the TrainingRuntime or ClusterTrainingRuntime as a runtime,
the TrainJob terminal condition (`Failed` or `Completed`) is decided based on the JobSet terminal state (`status.terminalState`)
the TrainJob terminal condition (`Failed` or `Complete`) is decided based on the JobSet terminal state (`status.terminalState`)
instead of computing from JobSet conditions.

```mermaid
Expand Down Expand Up @@ -986,8 +986,8 @@ stateDiagram-v2
Failed=True --> [*]
#COMPLETION
terminal_choice --> Completed=True: Actual Jobs (e.g., JobSet) completed.
Completed=True --> [*]
terminal_choice --> Complete=True: Actual Jobs (e.g., JobSet) completed.
Complete=True --> [*]
```

In the above state transition, the `Created=False` will happen in the following situations and
Expand Down

0 comments on commit 58d8587

Please sign in to comment.