-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sdk): Add error handling. Fixes #11164 #11356
fix(sdk): Add error handling. Fixes #11164 #11356
Conversation
Hi @Yael-F. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Yael-F.
I just left a minor suggestion.
Also, can you:
/ok-to-test
df7e1c1
to
f55ebe9
Compare
/lgtm |
@Yael-F thank you, apologies for the wait this lgtm, I was able to test and confirm this addresses the original issue can you rebase your PR and also add these changes to: https://github.com/kubeflow/pipelines/blob/master/sdk/RELEASE.md#bug-fixes-and-other-changes happy to approve once done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Signed-off-by: Yael <[email protected]>
f55ebe9
to
bfab212
Compare
@HumairAK rebased and updated https://github.com/kubeflow/pipelines/blob/master/sdk/RELEASE.md#bug-fixes-and-other-changes If you can please review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/ok-to-test
/ok-to-test |
1 similar comment
/ok-to-test |
Approvals successfully granted for pending runs. |
/approve thank you @Yael-F for your contribution! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
Fixes #11164 by adding error handling for image build/push failures in the KFP SDK. Now, errors trigger a clear error message and a non-zero exit code, ensuring accurate feedback to users.
Checklist: