Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sdk): Add error handling. Fixes #11164 #11356

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

Yael-F
Copy link
Contributor

@Yael-F Yael-F commented Nov 5, 2024

Description of your changes:

Fixes #11164 by adding error handling for image build/push failures in the KFP SDK. Now, errors trigger a clear error message and a non-zero exit code, ensuring accurate feedback to users.

Checklist:

Copy link

Hi @Yael-F. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Yael-F.
I just left a minor suggestion.
Also, can you:

/ok-to-test

sdk/python/kfp/cli/component.py Show resolved Hide resolved
@hbelmiro
Copy link
Contributor

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Nov 14, 2024
@HumairAK HumairAK added this to the KFP SDK 2.11 milestone Nov 14, 2024
@github-actions github-actions bot added the ci-passed All CI tests on a pull request have passed label Nov 26, 2024
@HumairAK
Copy link
Collaborator

HumairAK commented Nov 26, 2024

@Yael-F thank you, apologies for the wait

this lgtm, I was able to test and confirm this addresses the original issue

can you rebase your PR and also add these changes to: https://github.com/kubeflow/pipelines/blob/master/sdk/RELEASE.md#bug-fixes-and-other-changes

happy to approve once done!

Copy link
Contributor

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Yael-F
Copy link
Contributor Author

Yael-F commented Dec 2, 2024

Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test

@google-oss-prow google-oss-prow bot added the lgtm label Dec 2, 2024
@HumairAK
Copy link
Collaborator

HumairAK commented Dec 2, 2024

/ok-to-test

1 similar comment
@HumairAK
Copy link
Collaborator

HumairAK commented Dec 2, 2024

/ok-to-test

Copy link

github-actions bot commented Dec 2, 2024

Approvals successfully granted for pending runs.

@HumairAK
Copy link
Collaborator

HumairAK commented Dec 2, 2024

/approve

thank you @Yael-F for your contribution!

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HumairAK

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 4a64fe9 into kubeflow:master Dec 3, 2024
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed All CI tests on a pull request have passed lgtm ok-to-test size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sdk] KFP SDK prints "Built and pushed" despite push errors
4 participants