-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tests): remove redundant integration test wf #11322
Conversation
Signed-off-by: droctothorpe <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/ok-to-test |
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we tackle eliminating integration-test.sh
@droctothorpe can you remove the file in this PR.
and some of the corresponding out of date docs
FYI, We have an open issue for that: #11061
Signed-off-by: droctothorpe <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for addressing my suggestions @droctothorpe.
I suggest we tackle eliminating integration-test.sh
@droctothorpe can you remove the file in this PR.
You probably missed this comment. Can we remove the file in this PR if it doesn't impact anything?
Done! 👍 |
Signed-off-by: droctothorpe <[email protected]>
Based on @hbelmiro suggestions that was already addressed, I believe we're good to go. /lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @droctothorpe.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HumairAK The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Just to share a bit history, in the past, sample tests and integration tests are different workflows, IIRC, the former runs against the latest release--we do this by maintaining a long running deployment and update it post every release--while the latter runs against the built from master head + the PR being tested--developing on the fly. |
Description of your changes:
Identical sample tests are being run in two separate CI workflows for some reason: kfp-samples and kubeflow-pipelines-integration-v2. The first invokes
sample_test.py
. The second does as well (after pathing through a Makefile). Presumably, we don’t need both.I suggest we tackle eliminating
integration-test.sh
and some of the corresponding out of date docs in a follow-up PR. There should be one, clearly documented path for running large tests both in CI and from local.Checklist: