Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve(ws): replace reflect.DeepEqual with equality.Semantic.DeepEqual #152

Open
wants to merge 1 commit into
base: notebooks-v2
Choose a base branch
from

Conversation

Adembc
Copy link
Contributor

@Adembc Adembc commented Dec 4, 2024

Closes #69

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kimwnasptd for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@thesuperzapper
Copy link
Member

@Adembc one thing we might need to check is that we aren't constructing any explicit empty values for fields with omitempty.

Although that issue is more about the status field, and we might actually have this issue already because we use reflect.DeepEqual to check if we should update the status (so if we have explicitly constructed one of the fields as an empty list, like RedirectChain it will always update the status every reconcile).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Needs Triage
Development

Successfully merging this pull request may close these issues.

2 participants