Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce ManagedBy field in RunPolicy #650

Merged
merged 11 commits into from
Oct 10, 2024

Conversation

mszadkow
Copy link
Contributor

@mszadkow mszadkow commented Sep 21, 2024

Add support for ManagedBy to be able delegate reconciliation process to external controller.

Fixes #646

@google-oss-prow google-oss-prow bot requested review from carmark and zw0610 September 21, 2024 06:33
@mszadkow mszadkow force-pushed the feature/introduce-managedby branch 3 times, most recently from 9d9f891 to 4e57d1a Compare September 23, 2024 13:01
@mszadkow mszadkow marked this pull request as ready for review September 23, 2024 13:02
@google-oss-prow google-oss-prow bot requested a review from gaocegege September 23, 2024 13:02
@alculquicondor
Copy link
Collaborator

/ok-to-test

@mszadkow mszadkow force-pushed the feature/introduce-managedby branch 2 times, most recently from 971770b to 08d9e2f Compare September 23, 2024 14:04
@mszadkow mszadkow force-pushed the feature/introduce-managedby branch from 08d9e2f to 00e84e1 Compare September 23, 2024 14:59
@mszadkow mszadkow force-pushed the feature/introduce-managedby branch from 00e84e1 to 0e35914 Compare September 24, 2024 09:36
pkg/apis/kubeflow/v2beta1/types.go Outdated Show resolved Hide resolved
pkg/apis/kubeflow/v2beta1/types.go Outdated Show resolved Hide resolved
pkg/apis/kubeflow/v2beta1/types.go Outdated Show resolved Hide resolved
pkg/controller/mpi_job_controller_test.go Show resolved Hide resolved
test/e2e/mpi_job_test.go Outdated Show resolved Hide resolved
test/e2e/mpi_job_test.go Show resolved Hide resolved
pkg/controller/mpi_job_controller_test.go Show resolved Hide resolved
@mszadkow mszadkow force-pushed the feature/introduce-managedby branch 2 times, most recently from 2381586 to bc37bfd Compare September 26, 2024 07:04
@alculquicondor
Copy link
Collaborator

@tenzen-y anything else to add?

Signed-off-by: Michal Szadkowski <[email protected]>
@mszadkow mszadkow force-pushed the feature/introduce-managedby branch from bc37bfd to 4ac4cb2 Compare October 1, 2024 15:32
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I left minor comments.
Otherwise lgtm

test/e2e/mpi_job_test.go Outdated Show resolved Hide resolved
test/e2e/mpi_job_test.go Show resolved Hide resolved
test/integration/mpi_job_controller_test.go Outdated Show resolved Hide resolved
Signed-off-by: Michal Szadkowski <[email protected]>
@mszadkow mszadkow force-pushed the feature/introduce-managedby branch from c199396 to 08a3ac8 Compare October 2, 2024 11:54
Signed-off-by: Michal Szadkowski <[email protected]>
@mszadkow mszadkow force-pushed the feature/introduce-managedby branch from 26d3283 to e1eae61 Compare October 7, 2024 11:28
pkg/apis/kubeflow/v2beta1/types.go Show resolved Hide resolved
test/integration/mpi_job_controller_test.go Outdated Show resolved Hide resolved
test/e2e/mpi_job_test.go Outdated Show resolved Hide resolved
Replace backoff and consistently with sleep

Signed-off-by: Michal Szadkowski <[email protected]>
@mszadkow mszadkow force-pushed the feature/introduce-managedby branch from 983e2da to f91b8d2 Compare October 8, 2024 09:39
Copy link
Member

@tenzen-y tenzen-y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
/approve

Leave lgtm on @alculquicondor

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Collaborator

@alculquicondor alculquicondor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

pkg/apis/kubeflow/v2beta1/types.go Show resolved Hide resolved
@google-oss-prow google-oss-prow bot added the lgtm label Oct 10, 2024
@google-oss-prow google-oss-prow bot merged commit c29c37c into kubeflow:master Oct 10, 2024
10 checks passed
@mszadkow mszadkow deleted the feature/introduce-managedby branch October 11, 2024 09:09
@mszadkow
Copy link
Contributor Author

@alculquicondor @tenzen-y
please take a look
#656

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for the managedBy field
4 participants