-
Notifications
You must be signed in to change notification settings - Fork 221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce ManagedBy field in RunPolicy #650
Introduce ManagedBy field in RunPolicy #650
Conversation
9d9f891
to
4e57d1a
Compare
/ok-to-test |
971770b
to
08d9e2f
Compare
Signed-off-by: Michal Szadkowski <[email protected]>
Signed-off-by: Michal Szadkowski <[email protected]>
Signed-off-by: Michal Szadkowski <[email protected]>
08d9e2f
to
00e84e1
Compare
Signed-off-by: Michal Szadkowski <[email protected]>
Signed-off-by: Michal Szadkowski <[email protected]>
Signed-off-by: Michal Szadkowski <[email protected]>
00e84e1
to
0e35914
Compare
2381586
to
bc37bfd
Compare
@tenzen-y anything else to add? |
Signed-off-by: Michal Szadkowski <[email protected]>
bc37bfd
to
4ac4cb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. I left minor comments.
Otherwise lgtm
Signed-off-by: Michal Szadkowski <[email protected]>
c199396
to
08a3ac8
Compare
Signed-off-by: Michal Szadkowski <[email protected]>
26d3283
to
e1eae61
Compare
Replace backoff and consistently with sleep Signed-off-by: Michal Szadkowski <[email protected]>
…ait constants Signed-off-by: Michal Szadkowski <[email protected]>
983e2da
to
f91b8d2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/approve
Leave lgtm on @alculquicondor
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@alculquicondor @tenzen-y |
Add support for ManagedBy to be able delegate reconciliation process to external controller.
Fixes #646