-
Notifications
You must be signed in to change notification settings - Fork 444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(example): fix the broken link. #2433
doc(example): fix the broken link. #2433
Conversation
@@ -18,7 +18,7 @@ You have to install the following Python SDK to run these examples: | |||
The Notebooks examples run Pipelines in multi-user mode and your Kubeflow Notebook | |||
must have the appropriate `PodDefault` with the `pipelines.kubeflow.org` audience. | |||
|
|||
Please follow [this guide](https://www.kubeflow.org/docs/components/pipelines/sdk/connect-api/#multi-user-mode) | |||
Please follow [this guide](https://www.kubeflow.org/docs/components/pipelines/operator-guides/multi-user/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@richardsliu @thesuperzapper @kubeflow/wg-pipeline-leads Should we use this guide to run KFP from Kubeflow Notebooks ?
https://www.kubeflow.org/docs/components/pipelines/user-guides/core-functions/connect-api/#serviceaccount-token-volume
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that we have multiple authentication methods now. I've updated the link now :)
/rerun-all |
@Electronic-Waste You might need to re-push your commit since we can't re-trigger workflow which is more than one month old. |
3081deb
to
8917a9d
Compare
@andreyvelich Done! It seems that CI is error and we need to wait for this PR to be ready: #2455 |
/rerun-all |
Signed-off-by: Electronic-Waste <[email protected]>
Signed-off-by: Electronic-Waste <[email protected]>
8917a9d
to
5d3b89d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Electronic-Waste!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
As @yehudit1987 discussed with me in the Slack, there is a missing guide link in the environment setting section : https://github.com/kubeflow/katib/blob/master/examples/v1beta1/kubeflow-pipelines/README.md#multi-user-pipelines-setup
We decided to fix it to make the guide accessible to new-comers.
cc👀 @yehudit1987 @kubeflow/wg-automl-leads
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Checklist: