-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SDK] Fix types error #2424
[SDK] Fix types error #2424
Conversation
Signed-off-by: helenxie-bit <[email protected]>
@helenxie-bit Thanks for fixing this, please can you verify locally that it resolves the issue ?
|
@andreyvelich @Electronic-Waste I have tested the example code in the issue locally with this version of SDK and it finished successfully. It should fix the problem. |
Thanks @helenxie-bit, it works! |
@Electronic-Waste Glad to hear that! @andreyvelich Please review when you have time. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix @helenxie-bit!
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andreyvelich The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR adds
__init__.py
in types holder.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #2422
Checklist: